Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give template strings a different classification type #6513

Closed
DanielRosenwasser opened this issue Jan 16, 2016 · 2 comments
Closed

Give template strings a different classification type #6513

DanielRosenwasser opened this issue Jan 16, 2016 · 2 comments
Labels
API Relates to the public API for TypeScript Suggestion An idea for TypeScript Visual Studio Integration with Visual Studio Won't Fix The severity and priority of this issue do not warrant the time or complexity needed to fix it

Comments

@DanielRosenwasser
Copy link
Member

At the time, we just used "stringLiteral" because it was such a PITA to sync between the managed side and whatnot. We never followed up on it. Prompted by #6508.

Open questions:

  1. Do we want to classify ${ and } specially?
  2. If we do want to classify ${ and } specially in templates, do we want to classify backticks?
  3. What colors do we want to use in VS?

@derekcicerone @basarat

@DanielRosenwasser DanielRosenwasser added Bug A bug in TypeScript Visual Studio Integration with Visual Studio API Relates to the public API for TypeScript labels Jan 16, 2016
@derekcicerone-zz
Copy link

Thanks for checking. I don't have a strong opinion on the highlighting for string templates. It never hurts to have more specific classifications though - worst case we can keep coloring as strings. The syntax coloring I'd still really like is to distinguish between a normal comment and JSDoc.

@basarat
Copy link
Contributor

basarat commented Jan 17, 2016

I am very happy with what is there currently in the syntactic analyzer (the one between lexical and semantic) 🌹 that I am using as a work in progress in alm.tools

@mhegazy mhegazy added Suggestion An idea for TypeScript and removed Bug A bug in TypeScript labels Feb 24, 2016
@DanielRosenwasser DanielRosenwasser added the Won't Fix The severity and priority of this issue do not warrant the time or complexity needed to fix it label Dec 21, 2016
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
API Relates to the public API for TypeScript Suggestion An idea for TypeScript Visual Studio Integration with Visual Studio Won't Fix The severity and priority of this issue do not warrant the time or complexity needed to fix it
Projects
None yet
Development

No branches or pull requests

4 participants