Newlines removed/incorrect code generated for getPasteEdits

[DanielRosenwasser]

Imagine the following file:

// comment

function f() {}

When I press Ctrl+x on the line containing f, and paste it again, what VS Code does is it creates a buffer with the following contents:

// comment

and then sends **this request for paste edits**

 {
    "file": "d:\\scratch\\copypasta\\src\\file.ts",
    "pastedText": [
        "function f() {}\r\n"
    ],
    "pasteLocations": [
        {
            "start": {
                "line": 2,
                "offset": 1
            },
            "end": {
                "line": 2,
                "offset": 1
            }
        }
    ],
    "copiedFrom": {
        "file": "d:\\scratch\\copypasta\\src\\file.ts",
        "spans": [
            {
                "start": {
                    "line": 3,
                    "offset": 1
                },
                "end": {
                    "line": 3,
                    "offset": 16
                }
            }
        ]
    }
}

and receives **this response**.

{
    "edits": [
        {
            "fileName": "d:/scratch/copypasta/src/file.ts",
            "textChanges": [
                {
                    "start": {
                        "line": 1,
                        "offset": 15
                    },
                    "end": {
                        "line": 1,
                        "offset": 15
                    },
                    "newText": "function f() {}\r\n"
                }
            ]
        }
    ],
    "fixId": "providePostPasteEdits"
}

After the paste, the file no longer contains the original contents, and instead contains invalid text.

// commentfunction f() {}

[DanielRosenwasser]

This is not necessarily specific to comments. I think a related issue is the following:

function f() {

}

[|function g() {
    
}|]

1. Select the given range.
2. Cut the text of the range.
3. Paste the text of the range (requesting paste edits)

This generates the following files:

function f() {

}
function g() {
    
}

Note the missing newline before g and the extra newline after g.

[fatcerberus]

Wait, what are paste edits? I don’t think I’ve encountered that term before.

[DanielRosenwasser]

Wait, what are paste edits? I don’t think I’ve encountered that term before.

It's basically a command for editors to request a "smarter" copy/paste that can do things like auto-imports. See #57262 and #50187.