Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#53258 breaks ckeditor__ckeditor5-upload on DT #53459

Closed
sandersn opened this issue Mar 23, 2023 · 3 comments · Fixed by #53464
Closed

#53258 breaks ckeditor__ckeditor5-upload on DT #53459

sandersn opened this issue Mar 23, 2023 · 3 comments · Fixed by #53464
Assignees
Labels
Add a Flag Any problem can be solved by flags, except for the problem of having too many flags Bug A bug in TypeScript Fix Available A PR has been opened for this issue Recent Regression This is a new regression just found in the last major/minor version of TypeScript.

Comments

@sandersn
Copy link
Member

Here is a small repro based on that package:

export default class FileReader implements Observable {
    set(option: Record<string, unknown>): void;
    set(name: string, value: unknown): void;
}
export interface Observable {
    set(...args: [option: Record<string, unknown>] | [name: string, value: unknown] | [name: string]): void;
}
@sandersn sandersn added Add a Flag Any problem can be solved by flags, except for the problem of having too many flags Recent Regression This is a new regression just found in the last major/minor version of TypeScript. labels Mar 23, 2023
@sandersn sandersn added this to the TypeScript 5.1.0 milestone Mar 23, 2023
@jakebailey
Copy link
Member

I might be wrong but the second overload is already an error in TS 5.0; is that intentional?

@jakebailey
Copy link
Member

Oh, nevermind; it's missing declare.

@jakebailey
Copy link
Member

I think I may just revert my PR and try and go for fixing #53398 instead.

@jakebailey jakebailey added Bug A bug in TypeScript Add a Flag Any problem can be solved by flags, except for the problem of having too many flags and removed Add a Flag Any problem can be solved by flags, except for the problem of having too many flags labels Mar 23, 2023
@typescript-bot typescript-bot added the Fix Available A PR has been opened for this issue label Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Add a Flag Any problem can be solved by flags, except for the problem of having too many flags Bug A bug in TypeScript Fix Available A PR has been opened for this issue Recent Regression This is a new regression just found in the last major/minor version of TypeScript.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants