Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"importModuleSpecifierEnding" : "js" has no effect on import fixes from inside node_modules #48991

Closed
vdegenne opened this issue May 6, 2022 · 6 comments · Fixed by #48995
Closed
Assignees
Labels
Bug A bug in TypeScript Fix Available A PR has been opened for this issue

Comments

@vdegenne
Copy link

vdegenne commented May 6, 2022

2022-05-06.15-24-34.mp4

Typescript : 4.6.4
VSCode : 1.67.0
NodeJs : 16.13.0

I've tried to disable all extensions, but the issue persists.

If I use "moduleResolution" : "NodeNext" in my tsconfig.json file the js extension is attached to the import but it messes everything up.

@vdegenne
Copy link
Author

vdegenne commented May 6, 2022

@MartinJohns mind explaining the down vote ?

@MartinJohns
Copy link
Contributor

Ignoring the issue template for bug reports. Posting a video instead of a concise example and description of the behaviour.

@vdegenne
Copy link
Author

vdegenne commented May 6, 2022

@MartinJohns I thought more interesting to catch the issue as is while I encountered it in my environment (I also made sure to provide an easy to understand video by showing the essential parts).
Additional information has been added below the video.
The title says it all.
The video shows the actual behavior, and I show the expected one by trying to find a temporary solution.
A video is worth thousands of words.
If I didn't care I wouldn't be posting here in the first place to help the community...

@xiBread
Copy link

xiBread commented May 6, 2022

The issue template exists for a reason.

@vdegenne
Copy link
Author

vdegenne commented May 6, 2022

@xiBread last time I followed the template, one dev asked me to provide a gif/video instead, so again, I did it with care in mind.

Can you be annoying elsewhere ?

@andrewbranch
Copy link
Member

The GIF is great but ideally we would get it in addition to the issue template. No big deal this time, just something to keep in mind for the future. That said, personal attacks won’t be tolerated here. It’s Friday morning and I’ve barely finished my coffee, everyone chill and be nice to each other.

@microsoft microsoft locked and limited conversation to collaborators May 6, 2022
@andrewbranch andrewbranch added the Bug A bug in TypeScript label May 6, 2022
@andrewbranch andrewbranch self-assigned this May 6, 2022
@andrewbranch andrewbranch added this to the TypeScript 4.7.1 milestone May 6, 2022
@andrewbranch andrewbranch changed the title "importModuleSpecifierEnding" : "js" has no effect "importModuleSpecifierEnding" : "js" has no effect on import fixes from inside node_modules May 6, 2022
@typescript-bot typescript-bot added the Fix Available A PR has been opened for this issue label May 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug A bug in TypeScript Fix Available A PR has been opened for this issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants