-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Method override completions #45670
Comments
We should be able to use VS Code's snippet syntax for this style of completion. I originally proposed snippet style completions in #25207. It sounds like we have already have adopted a subset of VS Code's snippet string syntax This would need to be an opt-in feature for editors and we would likely need to add a user facing setting to disable these too |
A general question I have about these snippet completions that may insert quite a bit of text is how we want to display them. Xcode has these kinds of method signature completions and it looks like they just truncate, which isnβt too bad: Itβs somewhat less clear how #40700 should display, for example, which is another use case Iβm interested in exploring. |
I think we can start by using the full method signature text as the label like Xcode does here and see how we like it. @mjbvz pointed out that the |
I've wanted this one for so long and assumed it was already suggested, but didn't know what to search for. I'm surprised it only got added to the tracker last month β this would be such a huge usability enhancement for implementing abstract classes! It's honestly one of the only reasons why I sometimes miss working on Java projects π Will this completion automatically propagate visibility modifiers? IE, if the superclass has |
I've been working on implementing this feature, and the |
Suggestion
π Search Terms
β Suggestion
For the code:
I should be able to type
f
inside the body ofSub
and get a suggestion forfoo
that fills in the entire signature of the method when accepted:Right now, accepting the suggestion for foo only inserts the text
foo
. I have to fill out the entire body of the method myself, typically by copy and pasting from the base classThe text was updated successfully, but these errors were encountered: