Add way to differentiate references for definitions at requesting location #42889
Labels
Domain: Symbol Navigation
Relates to go-to-definition, find-all-references, highlighting/occurrences.
Fix Available
A PR has been opened for this issue
In Discussion
Not yet reached consensus
Suggestion
An idea for TypeScript
VS Code Priority
Critical issues that VS Code needs fixed in the current TypeScript milestone
Milestone
Bug Report
🔎 Search Terms
Problem
We use the
references
request to power VS Code's references code lens feature. References returned by TS have an optionalisDefinition
property that tells if the reference is to a definition or not. We use this to avoid showing multiple references for a case such as:The references code lens basically just filtered out any references that are marked
isDefinition
However this also prevents us from showing the correct reference count in cases such as:
In this case, the two references to
foo
should have 1 reference, but we show 0 references because both references are definitions.microsoft/vscode#117021 shows another case with object literal shortcut
Proposal
We'd like a new property on the references response that tells us if the reference belongs to definition from the requesting location (not yet sure what the name of this should be).
For a case with overloads such as:
If we request references on any of the calls to
foo
, this new property would be marked true. However it would not be true in cases such as:or:
The text was updated successfully, but these errors were encountered: