Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

baseUrl is used to create reference type path in declaration file #39695

Closed
sheetalkamat opened this issue Jul 21, 2020 · 4 comments
Closed

baseUrl is used to create reference type path in declaration file #39695

sheetalkamat opened this issue Jul 21, 2020 · 4 comments
Assignees
Labels
Bug A bug in TypeScript Duplicate An existing issue was already created Rescheduled This issue was previously scheduled to an earlier milestone

Comments

@sheetalkamat
Copy link
Member

npm run build is definitely bug and #39645 fixes that.

npm run build-baseUrl well that raises questions. #32878 started preferring types over reference paths to make it more portable. But our resolve type reference name doesnt use baseUrl so this is kind of questionable.
Other way to look at it would be when file is referenced throught only referece path from root file tree (or relative imports) prefer relative path instead of portable path.

Originally posted by @sheetalkamat in #37928 (comment)

@sheetalkamat sheetalkamat self-assigned this Jul 21, 2020
@sheetalkamat sheetalkamat added the Bug A bug in TypeScript label Jul 21, 2020
@sheetalkamat sheetalkamat added this to the TypeScript 4.0.1 milestone Jul 21, 2020
@sheetalkamat
Copy link
Member Author

sheetalkamat commented Jul 24, 2020

Note that this is not regression since previous release. #32878 introduced this which is around for sometime now.

@sheetalkamat
Copy link
Member Author

This needs more work and time to bake in so we can emit correct paths and falls into type reference resolution and declaration emit to match those expectations and hence kind of dependent on #39708

@Griffork
Copy link

Griffork commented Dec 7, 2020

This seems related to #34749 ? Presence of the baseUrl is breaking compiles in my project because ///reference path gets converted to an invalid ///reference types.

@sheetalkamat
Copy link
Member Author

Duplicate of #34749

@sheetalkamat sheetalkamat marked this as a duplicate of #34749 Nov 16, 2023
@sheetalkamat sheetalkamat added the Duplicate An existing issue was already created label Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A bug in TypeScript Duplicate An existing issue was already created Rescheduled This issue was previously scheduled to an earlier milestone
Projects
None yet
Development

No branches or pull requests

4 participants