Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduction of the awaited operator makes a lot of breaks #37511

Closed
falsandtru opened this issue Mar 21, 2020 · 2 comments · Fixed by #37610
Closed

Introduction of the awaited operator makes a lot of breaks #37511

falsandtru opened this issue Mar 21, 2020 · 2 comments · Fixed by #37610
Labels
Needs More Info The issue still hasn't been fully clarified

Comments

@falsandtru
Copy link
Contributor

falsandtru commented Mar 21, 2020 •
edited
Loading

@rbuckton @DanielRosenwasser

Because of the awaited operator, today's build makes a lot of breaks in https://github.com/falsandtru/spica. I believe the other projects will also get many breaks. Can you really release this breaking change? I'm not sure whether I should fix the breaks.
@falsandtru falsandtru changed the title Supporting awaited predicate makes a lot of breaks Supporting awaited operator makes a lot of breaks Mar 21, 2020
@falsandtru falsandtru changed the title Supporting awaited operator makes a lot of breaks Introduction of the awaited operator makes a lot of breaks Mar 21, 2020
@RyanCavanaugh RyanCavanaugh added the Needs More Info The issue still hasn't been fully clarified label Mar 22, 2020
@falsandtru
Copy link
Contributor Author

Here is a fix of the breaks made by awaited operator.

falsandtru/spica@c569afd

@falsandtru
Copy link
Contributor Author

@RyanCavanaugh We should add the awaited label to the related issues to review feedback: #37501

@rbuckton rbuckton mentioned this issue Mar 25, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Needs More Info The issue still hasn't been fully clarified
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Revert 'awaited' type microsoft/TypeScript
2 participants
@falsandtru @RyanCavanaugh