Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing error for trailing comma in dynamic import arguments #29545

Closed
ajafff opened this issue Jan 23, 2019 · 1 comment
Closed

Missing error for trailing comma in dynamic import arguments #29545

ajafff opened this issue Jan 23, 2019 · 1 comment
Labels
Bug A bug in TypeScript Good First Issue Well scoped, documented and has the green light Help Wanted You can do this
Milestone
Backlog

Comments

@ajafff
Copy link
Contributor

ajafff commented Jan 23, 2019

TypeScript Version: 3.3.0-dev.20190119

Search Terms:

Code

import('foo',);

Expected behavior:

Error on the trailing comma as the spec/proposal currently disallows it: tc39/proposal-dynamic-import#15

Actual behavior:

No grammar error, instead this results in a parse error when executed after transpiling with module: ESNext

Playground Link:

Related Issues:

@RyanCavanaugh RyanCavanaugh added Bug A bug in TypeScript Help Wanted You can do this Good First Issue Well scoped, documented and has the green light labels Jan 23, 2019
@RyanCavanaugh RyanCavanaugh added this to the Community milestone Jan 23, 2019
@fuafa fuafa mentioned this issue Jan 24, 2019
Merged
@RyanCavanaugh
Copy link
Member

Thanks @fuafa and congrats on your first contribution 😄

@RyanCavanaugh RyanCavanaugh modified the milestones: Community, Backlog Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug A bug in TypeScript Good First Issue Well scoped, documented and has the green light Help Wanted You can do this
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
2 participants
@RyanCavanaugh @ajafff