undefined error in isPropertyAccessExpression

[ivogabe]

TypeScript Version: 3.1.0-dev.20180907
(3.0.3 works fine)

Search Terms:
isPropertyAccessExpression undefined kind

Code
I couldn't replicate this in a small example. The bug can be reproduced with the following steps:

• Download https://github.com/ivogabe/gulp-typescript/tree/1b655ff5ea4a84889af509bb433bf6a809aebae3
• npm install
• npm install [email protected]
• ./node_modules/.bin/tsc -p lib

Expected behavior:
Compilation succeeds without errors

Actual behavior:

[..]/node_modules/typescript/lib/tsc.js:68651
                throw e;
                ^

TypeError: Cannot read property 'kind' of undefined
    at Object.isPropertyAccessExpression ([..]/node_modules/typescript/lib/tsc.js:9975:20)
    at [..]/node_modules/typescript/lib/tsc.js:46202:91
    at Object.forEachEntry ([..]/node_modules/typescript/lib/tsc.js:5689:26)
    at Object.isJSContainerFunctionDeclaration ([..]/node_modules/typescript/lib/tsc.js:46202:25)
    at transformTopLevelDeclaration ([..]/node_modules/typescript/lib/tsc.js:63058:43)
    at visitDeclarationStatements ([..]/node_modules/typescript/lib/tsc.js:63020:26)
    at Object.visitNodes ([..]/node_modules/typescript/lib/tsc.js:51643:48)
    at transformRoot ([..]/node_modules/typescript/lib/tsc.js:62524:33)
    at [..]/node_modules/typescript/lib/tsc.js:1203:42
    at transformRoot ([..]/node_modules/typescript/lib/tsc.js:63498:82)

Related Issues:
#26964
#26978
#26832

[sandersn]

Probably due to expando functions, because I think the only thing in lib/ is .ts files.

Edit: That is, it's not likely related to the 3 linked issues, but is related to a few already-closed issues.

[sandersn]

isExpandoFunctionDeclaration assumes that all exports are values, which have valueDeclarations. But namespaces can export types, which do not. Here's a short repro:

// @declaration: true
function compile(): void { }
namespace compile {
    export interface Settings { }
}

I have a fix and as soon as I add a test, I'll send out a PR.

[ivogabe]

Thanks for the quick fix! I'll test the next nightly

[blink1073]

@sandersn, I am still seeing this behavior with ~3.1.0-dev.20180922

[blink1073]

Repro:

git clone https://github.com/blink1073/jupyterlab --branch use-ts-31
cd jupyterlab
yarn
yarn build:packages

[blink1073]

I tried @ivogabe's repro with ~3.1.0-dev.20180922 and that now builds fine.

[sandersn]

@blink1073 I’ll try your repro when I’m at my desk. Unless your stack trace is identical, then it’s likely a different issue.

[blink1073]

I'm afk, but my stack trace was identical, and was what led me to this issue.

[sandersn]

Hmm. I just tried the repro and it doesn't happen with builds from Friday (9/21) or today (9/24) or 3.1.0-dev.20180922.

Note that I couldn't get yarn build:packages to work because of its dependency on jlpm, which seems just to be a custom-wrapped yarn (?). So I followed the tasks in package.json and it looks like build:packages just calls tsc -b src inside packages/metapackage. If that's not right, let me know.

[blink1073]

Thanks for checking! That sounds right as far as procedure. I'll try again when I get back.

[blink1073]

Hmm, this is still happening for me with "typescript": "~3.1.0-dev.20180925":

$ ./node_modules/.bin/tsc -b src
/Users/ssilvester/workspace/jupyter/lab/node_modules/typescript/lib/tsc.js:69059
                throw e;
                ^

TypeError: Cannot read property 'kind' of undefined
    at Object.isPropertyAccessExpression (/Users/ssilvester/workspace/jupyter/lab/node_modules/typescript/lib/tsc.js:10282:20)
    at /Users/ssilvester/workspace/jupyter/lab/node_modules/typescript/lib/tsc.js:46606:91
    at Object.forEachEntry (/Users/ssilvester/workspace/jupyter/lab/node_modules/typescript/lib/tsc.js:5976:26)
    at Object.isJSContainerFunctionDeclaration (/Users/ssilvester/workspace/jupyter/lab/node_modules/typescript/lib/tsc.js:46606:25)
    at transformTopLevelDeclaration (/Users/ssilvester/workspace/jupyter/lab/node_modules/typescript/lib/tsc.js:63465:43)
    at visitDeclarationStatements (/Users/ssilvester/workspace/jupyter/lab/node_modules/typescript/lib/tsc.js:63427:26)
    at Object.visitNodes (/Users/ssilvester/workspace/jupyter/lab/node_modules/typescript/lib/tsc.js:52047:48)
    at transformRoot (/Users/ssilvester/workspace/jupyter/lab/node_modules/typescript/lib/tsc.js:62928:33)
    at /Users/ssilvester/workspace/jupyter/lab/node_modules/typescript/lib/tsc.js:1204:42
    at transformRoot (/Users/ssilvester/workspace/jupyter/lab/node_modules/typescript/lib/tsc.js:63905:82)

[blink1073]

False alarm, I ran git clean -dfx and tried again, and all is well. Thanks again!

[blink1073]

No, something is definitely not right. It is still failing on CI: https://travis-ci.org/blink1073/jupyterlab/jobs/432833170#L638.

git clone https://github.com/blink1073/jupyterlab --branch use-ts-31
cd jupyterlab/packages/metapackage
yarn
yarn build

$ ./node_modules/.bin/tsc -b src
/Users/ssilvester/temp/jupyterlab/node_modules/typescript/lib/tsc.js:69059
                throw e;
                ^

TypeError: Cannot read property 'kind' of undefined
    at Object.isPropertyAccessExpression (/Users/ssilvester/temp/jupyterlab/node_modules/typescript/lib/tsc.js:10282:20)
    at /Users/ssilvester/temp/jupyterlab/node_modules/typescript/lib/tsc.js:46606:91
    at Object.forEachEntry (/Users/ssilvester/temp/jupyterlab/node_modules/typescript/lib/tsc.js:5976:26)
    at Object.isJSContainerFunctionDeclaration (/Users/ssilvester/temp/jupyterlab/node_modules/typescript/lib/tsc.js:46606:25)
    at transformTopLevelDeclaration (/Users/ssilvester/temp/jupyterlab/node_modules/typescript/lib/tsc.js:63465:43)
    at visitDeclarationStatements (/Users/ssilvester/temp/jupyterlab/node_modules/typescript/lib/tsc.js:63427:26)
    at Object.visitNodes (/Users/ssilvester/temp/jupyterlab/node_modules/typescript/lib/tsc.js:52047:48)
    at transformRoot (/Users/ssilvester/temp/jupyterlab/node_modules/typescript/lib/tsc.js:62928:33)
    at /Users/ssilvester/temp/jupyterlab/node_modules/typescript/lib/tsc.js:1204:42
    at transformRoot (/Users/ssilvester/temp/jupyterlab/node_modules/typescript/lib/tsc.js:63905:82)
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

[blink1073]

$ cat package.json | grep typescript
    "typescript": "~3.1.0-dev.20180925"

[blink1073]

If I change the tsc code to return node && node.kind === 187;, it builds fine.

[blink1073]

Interestingly, if I replace tsc.js with the one in the release-3.1 branch, it builds. If I still see the error with the final 3.1 release I'll open a new issue.

[jasongrout]

3.1 final is released now

[blink1073]

Works now locally and on CI! 🎉