ts.transpile() outputs CRLF as EOL in any OS

[teppeis]

CRLF is hardcoded:
https://github.com/Microsoft/TypeScript/blob/5e7343f573c3e987caaa3f2326386b8c796e6fa3/src/services/services.ts#L1683

[mhegazy]

@teppeis would the use of system-dependent line ending be good enough?

[teppeis]

@mhegazy yes, sys.newLine is good.

[nycdotnet]

FYI: The line endings question has come up in every meta-TypeScript project I've been involved in:

TypeStrong/atom-typescript#216
TypeStrong/grunt-ts#199

This issue is still open as accepting PR:

#1693

It's fine to default to the current system's default line ending but to solve this, it really should be overrideable via the tsconfig or a switch. I had intended to take a stab at 1693, but of course this is the sort of thing where the implementation is the easy part and naming the switch is the hard part. :-)

[mhegazy]

@nycdotnet i agree. i was initially going to do fix it by adding the flag. if you intend to send a PR for #1693 soon, then i would wait for it.

[nycdotnet]

I'll give it a shot and let you know either way in the next two weeks. Based on the ~80% 1.5 issues treadmill, I'm hopeful this should be in plenty of time.

[teppeis]

@mhegazy thanks!

[basarat]

Having looked at @nycdotnet 's list I am now inclined to say "os.eol" or death in the next meta ts project :)