Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go-to-definition on declarations in session.ts jumps to breakpoints.ts #24884

Closed
DanielRosenwasser opened this issue Jun 11, 2018 · 1 comment
Closed

Go-to-definition on declarations in session.ts jumps to breakpoints.ts #24884

DanielRosenwasser opened this issue Jun 11, 2018 · 1 comment
Assignees
@weswigham
Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue
Milestone
TypeScript 2.9.2

Comments

@DanielRosenwasser
Copy link
Member

Using the latest of master:

  1. Open up src/server/session.ts
  2. Go to definition on getSignatureHelpItems

Expected: Jumps to src/services/services.ts or src/services/signatureHelp.ts
Actual: Jumps to src/services/breakpoints.ts
@mhegazy mhegazy added this to the TypeScript 3.0 milestone Jun 11, 2018
@mhegazy mhegazy added the Bug A bug in TypeScript label Jun 11, 2018
@weswigham weswigham added the Fixed A PR has been merged for this issue label Jun 12, 2018
@weswigham
Copy link
Member

Fixed by #24886

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@weswigham weswigham

Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue
Projects
None yet
Milestone
TypeScript 2.9.2
Development

No branches or pull requests
3 participants
@DanielRosenwasser @weswigham @mhegazy