Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transparent go-to-def doesn't work in VS #23827

Closed
RyanCavanaugh opened this issue May 2, 2018 · 1 comment
Closed

Transparent go-to-def doesn't work in VS #23827

RyanCavanaugh opened this issue May 2, 2018 · 1 comment
Assignees
Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue

Comments

@RyanCavanaugh
Copy link
Member

TypeScript Version: master

Search Terms: visual studio declaration source map to go to definition

Code

foo.ts

bar;

bar.d.ts

declare var bar;

bar.d.ts.map

(sourcemap saying "go to ../src/bar")

../src/bar.ts

var bar;

Expected behavior: Goes to the def

Actual behavior: Cannot navigate to symbol under caret

Playground Link: N/A

Related Issues: #22658

Root cause here is that we are eagerly deserializing the references into DocumentItems, but there is no Document for bar.ts in foo.ts's project

@RyanCavanaugh RyanCavanaugh added the Bug A bug in TypeScript label May 2, 2018
@RyanCavanaugh RyanCavanaugh added this to the TypeScript 2.9 milestone May 2, 2018
@RyanCavanaugh RyanCavanaugh self-assigned this May 2, 2018
@mhegazy mhegazy added Fixed A PR has been merged for this issue and removed Fixed A PR has been merged for this issue labels May 8, 2018
@RyanCavanaugh
Copy link
Member Author

Currently mitigated by telling VS about the .d.ts file and providing the .ts location in an alternate field

@mhegazy mhegazy added the Fixed A PR has been merged for this issue label May 22, 2018
@mhegazy mhegazy closed this as completed May 22, 2018
@microsoft microsoft locked and limited conversation to collaborators Jul 31, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue
Projects
None yet
Development

No branches or pull requests

2 participants