Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No errors in editor: session does not support events #22790

Closed
ghost opened this issue Mar 22, 2018 · 1 comment
Closed

No errors in editor: session does not support events #22790

ghost opened this issue Mar 22, 2018 · 1 comment
Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue

Comments

@ghost
Copy link

ghost commented Mar 22, 2018

TypeScript Version: 2.8.0-dev.20180322 (works in 2.8.0-dev.20180321)

Search Terms:

Code

const x: number = "";

Expected behavior:

Shows the error.

Actual behavior:

From tsserver.log:

Info 78   [9:1:58.995] Session does not support events: ignored event: {"seq":0,"type":"event","event":"semanticDiag","body":{"file":"c:/Users/anhans/work/sample/ts/src/a.ts","diagnostics":[{"start":{"line":1,"offset":7},"end":{"line":1,"offset":8},"text":"Type '\"\"' is not assignable to type 'number'.","code":2322,"category":"error"}]}}
@ghost
Copy link
Author

ghost commented Mar 22, 2018

Works in the commit before #22591

@ghost ghost added the Bug A bug in TypeScript label Mar 22, 2018
@ghost ghost added the Fixed A PR has been merged for this issue label Mar 22, 2018
@mhegazy mhegazy added this to the TypeScript 2.9 milestone Mar 22, 2018
@ghost ghost closed this as completed in #22791 Mar 22, 2018
@microsoft microsoft locked and limited conversation to collaborators Jul 25, 2018
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue
Projects
None yet
Development

No branches or pull requests

1 participant