Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better type inference of tagged union predicate functions #18122

Closed
ccorcos opened this issue Aug 29, 2017 · 3 comments
Closed

Better type inference of tagged union predicate functions #18122

ccorcos opened this issue Aug 29, 2017 · 3 comments
Labels
Duplicate An existing issue was already created

Comments

@ccorcos
Copy link

ccorcos commented Aug 29, 2017

TypeScript Version: 2.4.0 / nightly (2.5.0-dev.201xxxxx)

Code

type X = {t: "x"}
type Y = {t: "y"}
type Z = X | Y

let a: Array<Z>

function predicate(x: Z) {
  return x.t === "x"
}

const result =  a.find(predicate)

Expected behavior:
I want result to have a type of X. Which means I want the predicate function to have a return type of x is X.

Actual behavior:
The result of the predicate is of type Z and result is of type Z

@mhegazy
Copy link
Contributor

mhegazy commented Aug 29, 2017

Please see #5101 (comment)

@mhegazy mhegazy added the Duplicate An existing issue was already created label Aug 29, 2017
@ccorcos
Copy link
Author

ccorcos commented Aug 31, 2017

Hmm. so I need to overload the .find function? Or should I be doing something like this?

function predicate<T extends Z>(x: Z): x is T {
  return x.t === "x"
}

@mhegazy
Copy link
Contributor

mhegazy commented Sep 19, 2017

Automatically closing this issue for housekeeping purposes. The issue labels indicate that it is unactionable at the moment or has already been addressed.

@mhegazy mhegazy closed this as completed Sep 19, 2017
@microsoft microsoft locked and limited conversation to collaborators Jun 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Duplicate An existing issue was already created
Projects
None yet
Development

No branches or pull requests

2 participants