Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discriminated Unions In Switch Statements Don't Respect Destructuring #15889

Closed
axxag opened this issue May 16, 2017 · 2 comments
Closed

Discriminated Unions In Switch Statements Don't Respect Destructuring #15889

axxag opened this issue May 16, 2017 · 2 comments
Labels
Duplicate An existing issue was already created

Comments

@axxag
Copy link

axxag commented May 16, 2017

TypeScript Version: 2.3.2

Code

interface Square {
    kind: "square";
    size: number;
}
interface Circle {
    kind: "circle";
    radius: number;
}

type Shape = Square | Circle

const area = (s: Shape) => { //Works
    switch (s.kind) {
        case "square": return s.size * s.size;
        case "circle": return Math.PI * s.radius ** 2;
    }
}

const area = (s: Shape) => {
    const {kind} = s
    switch (kind) {
        case "square": return s.size * s.size; // size doesn't exist on Circle
        case "circle": return Math.PI * s.radius ** 2;  // radius doesn't exist on Square
    }
}
@mhegazy
Copy link
Contributor

mhegazy commented May 16, 2017

Duplicate of #10976

@mhegazy mhegazy added the Duplicate An existing issue was already created label May 16, 2017
@mhegazy
Copy link
Contributor

mhegazy commented Jun 2, 2017

Automatically closing this issue for housekeeping purposes. The issue labels indicate that it is unactionable at the moment or has already been addressed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Duplicate An existing issue was already created
Projects
None yet
Development

No branches or pull requests

2 participants