Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.3.1 TSX spread with union types #15432

Closed
kryops opened this issue Apr 28, 2017 · 2 comments
Closed

2.3.1 TSX spread with union types #15432

kryops opened this issue Apr 28, 2017 · 2 comments
Labels
Duplicate An existing issue was already created

Comments

@kryops
Copy link

kryops commented Apr 28, 2017

TypeScript Version: 2.3.1, 2.4.0-dev.20170427

Code

type Foo = { foo: string }
type Bar = { bar: string }
type Baz = { baz: string }

type FBB = Foo | Bar | Baz

declare const obj: FBB

const FbbComponent = (props: FBB) => (
    <div>{JSON.stringify(props)}</div>
)

const comp1 = React.createElement(FbbComponent, { ...obj }) // works
const comp2 = <FbbComponent {...obj as Foo} /> // works
const comp3 = <FbbComponent {...obj} /> // does not work

Expected behavior:

Compiles without errors

Actual behavior:
Error:

Type '{}' is not assignable to type '(IntrinsicAttributes & Foo) | (IntrinsicAttributes & Bar) | (IntrinsicAttributes & Baz)'.
  Type '{}' is not assignable to type 'IntrinsicAttributes & Baz'.
    Type '{}' is not assignable to type 'Baz'.
      Property 'baz' is missing in type '{}'.
@mhegazy
Copy link
Contributor

mhegazy commented Apr 28, 2017

This is a duplicate of #14112, #15420, #13557, and #14409 fixed by #13288.

@mhegazy mhegazy added the Duplicate An existing issue was already created label Apr 28, 2017
@mhegazy
Copy link
Contributor

mhegazy commented May 19, 2017

Automatically closing this issue for housekeeping purposes. The issue labels indicate that it is unactionable at the moment or has already been addressed.

@mhegazy mhegazy closed this as completed May 19, 2017
@microsoft microsoft locked and limited conversation to collaborators Jun 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Duplicate An existing issue was already created
Projects
None yet
Development

No branches or pull requests

2 participants