BUG : jsconfig.json file in $HOME crash computer #14636
Labels
Bug
A bug in TypeScript
Fixed
A PR has been merged for this issue
VS Code Tracked
There is a VS Code equivalent to this issue
Milestone
Comments
|
This seems to be one of the causes of the high CPU usage bug's we've seen. Here's the TSServer log: Eventually it the TSServer disables the language service. Then a little while later it crashes and restarts. Here's one of the typings install logs that is triggered: And here's the process info: |
|
A jsconfig.json with no |
|
This is kinda related to the other issue where the user doesn't know where the root of the project was set to. We could expose the information somewhere on the UI, so that the user can know if the Edit: |
|
microsoft/vscode#20571 was reverted as there were concerns about polluting the status bar. Instead we added some commands to jump to the current config file. One other problem I noticed when having a |
|
What about just opening loose files? VS supports those too. I understand that we should limit the number of files scanned/included. |
|
@mhegazy Yes, limiting the scanning would be the more complete fix here I still am wondering though: for loose files, should we really automatically load the project corresponding to the file when a user opens it? My thinking for VSCode is that if you have a workspace open and then open a file outside the workspace, we could just treat the opened file as a standalone file. If you are only opening loose files in VSCode (and have not opened any workspaces) then perhaps we should try to load the project for the files as well. This would be a regression in behavior though |
|
We can add a |
|
@mjbvz there is some work here for VSCode to use this change, you will need to pass the projectRootPath as appropriate. |
|
Great! I've opened microsoft/vscode#25040 to track this on our side. Please let me know when a new insiders build with this fix is available |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
From @DavidBabel on March 13, 2017 10:1
Steps to Reproduce:
linked to #22372
jsconfig.jsonfile in your $HOME directory with content :You will got huge performances problems identified, intellisense will completely crash in "loading ..." state, and the whole computer will slow down.
Processes stay as ghost even if vscode is closed.
Copied from original issue: microsoft/vscode#22515
The text was updated successfully, but these errors were encountered: