Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Object.assign static method signature #12109

Closed
falsandtru opened this issue Nov 8, 2016 · 4 comments
Closed

Enhance Object.assign static method signature #12109

falsandtru opened this issue Nov 8, 2016 · 4 comments
Labels
Duplicate An existing issue was already created

Comments

@falsandtru
Copy link
Contributor

falsandtru commented Nov 8, 2016

TypeScript Version: master

Code

#12110

+    assign<T>(target: T, source: T, ...sources: T[]): T;

-    assign<T, U>(target: T, source: U): T & U;
+    assign<T, U>(target: T, source: U, ...sources: U[]): T & U;
@mhegazy
Copy link
Contributor

mhegazy commented Nov 8, 2016

We have a few signatures for 2,3 , and 4 arguments. i am not convinced this adds much. #11100 tracks correctly typing this function. so i would say we should wait for #11100.

@falsandtru
Copy link
Contributor Author

I see, I introduce this in #11100.

@falsandtru
Copy link
Contributor Author

@mhegazy This patch don't conflict with #12114, is just an enhancement. So you can merge this patch.

@mhegazy
Copy link
Contributor

mhegazy commented Dec 13, 2016

@sandersn is working on a fix for this. i would rather we waited for that change.

@mhegazy mhegazy added the Duplicate An existing issue was already created label Dec 13, 2016
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Duplicate An existing issue was already created
Projects
None yet
Development

No branches or pull requests

2 participants