Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to tsconfig.json not picked up #11803

Closed
mhegazy opened this issue Oct 23, 2016 · 5 comments
Closed

Changes to tsconfig.json not picked up #11803

mhegazy opened this issue Oct 23, 2016 · 5 comments
Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue

Comments

@mhegazy
Copy link
Contributor

mhegazy commented Oct 23, 2016

// a.ts
Symbol.iterator;
{
    "compilerOptions": {
        "lib": [
            "es5",
            "dom"
        ]
    }
}
  1. open 'a.ts', there should be an error for missing Symbol definition
  2. change lib in tsconfig.json to include es6, and save
  3. make an edit in a.ts. expect the error to go away

Actual:

Error does not go away, closing and reopening the file does.

Expected:

Error goes away on next refresh.

@mhegazy mhegazy added the Bug A bug in TypeScript label Oct 23, 2016
@mhegazy mhegazy added this to the TypeScript 2.1 milestone Oct 23, 2016
@mhegazy mhegazy added 2.1 RC and removed 2.1 RC labels Oct 24, 2016
@mhegazy mhegazy modified the milestones: TypeScript 2.1, TypeScript 2.1.2 Oct 27, 2016
@mhegazy mhegazy assigned vladima and unassigned zhengbli Oct 31, 2016
@mhegazy
Copy link
Contributor Author

mhegazy commented Oct 31, 2016

@vladima can you take a look.

@vladima
Copy link
Contributor

vladima commented Oct 31, 2016

cannot repro on the latest master, is there anything else I need to do?

@mhegazy
Copy link
Contributor Author

mhegazy commented Oct 31, 2016

nope. i repro'ed this on 2.0.6

@mhegazy mhegazy added the Fixed A PR has been merged for this issue label Oct 31, 2016
@mhegazy mhegazy closed this as completed Oct 31, 2016
@stijnherreman
Copy link

@mhegazy Were you able to verify yourself that the issue was fixed?

I can repro this with VS 2017 Update 2. Changes to tsconfig.json are not picked up until I close and reopen main.ts.

tsconfig.json

{
  "compileOnSave": true,
  "compilerOptions": {
    "outDir": "../../wwwroot/js",
    "removeComments": false
  }
}

main.ts

export class Main
{
    // test comment
    constructor() {
        console.log("inside constructor");
    }

    foo(): void {
        console.log("inside foo");
    }
}

Changing the value of "removeComments" doesn't have any effect on the output until I've closed, reopened and re-saved the source file.

@mhegazy
Copy link
Contributor Author

mhegazy commented Jun 7, 2017

Looks fixed in Update 3. give it a try.
animation

@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue
Projects
None yet
Development

No branches or pull requests

4 participants