Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DataTransfer.types type incorrect (or maybe just incomplete). #10979

Closed
mitchellwills opened this issue Sep 19, 2016 · 1 comment · Fixed by microsoft/TypeScript-DOM-lib-generator#148
Closed

DataTransfer.types type incorrect (or maybe just incomplete). #10979

mitchellwills opened this issue Sep 19, 2016 · 1 comment · Fixed by microsoft/TypeScript-DOM-lib-generator#148
Labels
Bug A bug in TypeScript Domain: lib.d.ts The issue relates to the different libraries shipped with TypeScript Fixed A PR has been merged for this issue Help Wanted You can do this
Milestone
TypeScript 2.1.4

Comments

@mitchellwills
Copy link

TypeScript Version: Latest master rev (b7d1d11)

The type of the DataTransfer.types field does not match the spec, which seems to indicate that it should be of type DOMString[] not DOMStringList as it is today.
https://github.com/Microsoft/TypeScript/blob/b7d1d11ba32fe0aa01d7c06ad43c2c7f7d9ffb7f/lib/lib.dom.d.ts#L2191
https://html.spec.whatwg.org/multipage/interaction.html#the-datatransfer-interface

This appears to match the behavior of Chrome 53.0.2785.116; however, Firefox 48.0 shows the field being of type DOMStringList.
@RyanCavanaugh RyanCavanaugh added Bug A bug in TypeScript Help Wanted You can do this Domain: lib.d.ts The issue relates to the different libraries shipped with TypeScript labels Sep 19, 2016
@mhegazy
Copy link
Contributor

mhegazy commented Sep 21, 2016

PRs welcomed. You can find more information about contributing lib.d.ts fixes at https://github.com/Microsoft/TypeScript/blob/master/CONTRIBUTING.md#contributing-libdts-fixes.

@mhegazy mhegazy modified the milestone: Community Sep 21, 2016
@YuichiNukiyama YuichiNukiyama mentioned this issue Sep 23, 2016
Merged
@mhegazy mhegazy modified the milestones: TypeScript 2.1, Community Sep 29, 2016
@mhegazy mhegazy reopened this Sep 29, 2016
@mhegazy mhegazy added Fixed in TSJS repo Fix merged in https://github.com/Microsoft/TSJS-lib-generator, but not ported yet and removed Fixed in TSJS repo labels Oct 21, 2016
@mhegazy mhegazy modified the milestones: TypeScript 2.1, TypeScript 2.1.2 Oct 27, 2016
@mhegazy mhegazy mentioned this issue Oct 31, 2016
Merged
@mhegazy mhegazy added Fixed A PR has been merged for this issue and removed Fixed in TSJS repo Fix merged in https://github.com/Microsoft/TSJS-lib-generator, but not ported yet labels Oct 31, 2016
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Bug A bug in TypeScript Domain: lib.d.ts The issue relates to the different libraries shipped with TypeScript Fixed A PR has been merged for this issue Help Wanted You can do this
Projects
None yet
Milestone
TypeScript 2.1.4
Development

Successfully merging a pull request may close this issue.

change DataTransfer.types property from DOMStringList to string[] YuichiNukiyama/TSJS-lib-generator
4 participants
@mitchellwills @zhengbli @RyanCavanaugh @mhegazy