Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async methods highlight #50

Closed
EugenePisotsky opened this issue Jan 19, 2016 · 2 comments
Closed

Async methods highlight #50

EugenePisotsky opened this issue Jan 19, 2016 · 2 comments
Labels
needs more info Needs additional information to be able to be able to take action on the issue

Comments

@EugenePisotsky
Copy link

Async highlight is not working for decorated methods (Atom, atom-typescript 8.1)

    @Action('/promise')
    public async asyncResponse(): Promise<Object> {
        return {
            promiseResult: 'promise is ok'
        }
    }

also, class keyword now looks like type in this example:

export class IndexController extends AppController {
...

original issue: TypeStrong/atom-typescript#819

@zhengbli zhengbli added the bug label Jan 20, 2016
@anubmat anubmat added needs more info Needs additional information to be able to be able to take action on the issue and removed bug labels Jul 29, 2016
@anubmat
Copy link
Contributor

anubmat commented Jul 29, 2016

For part 1, is this being declared outside a class declaration, because the problem does not seem to be 'async', looks like it is with async and public being used outside class definition.
For part 2, Needs more info. It looks good to me now.

@sheetalkamat
Copy link
Member

Fixed by #257

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs more info Needs additional information to be able to be able to take action on the issue
Projects
None yet
Development

No branches or pull requests

4 participants