Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

String method names do not terminate string syntax highlighting #154

Closed
aeschli opened this issue Apr 25, 2016 · 2 comments
Closed

String method names do not terminate string syntax highlighting #154

aeschli opened this issue Apr 25, 2016 · 2 comments

Comments

@aeschli
Copy link

aeschli commented Apr 25, 2016

From @chadhietala on April 23, 2016 20:57

  • VSCode Version: 1.0.0
  • OS Version: OSX 10.10.5

Steps to Reproduce:

  1. Have a class with stings as method names
  2. Observe syntax highlighting is different from non-string method names

String Method Name
screen shot 2016-04-23 at 1 56 50 pm

Method Name
screen shot 2016-04-23 at 1 55 35 pm

Copied from original issue: microsoft/vscode#5703

@aeschli
Copy link
Author

aeschli commented Apr 25, 2016

Reproduced with the following snippet:

class TestCase {
    ['foo']() {
        this.registerComponent('foo-bar');
    }
}

class TestCase2 {
    foo() {
        this.registerComponent('foo-bar');
    }
}

chadhietala added a commit to chadhietala/TypeScript-TmLanguage that referenced this issue Jun 7, 2016
chadhietala added a commit to chadhietala/TypeScript-TmLanguage that referenced this issue Jun 27, 2016
chadhietala added a commit to chadhietala/TypeScript-TmLanguage that referenced this issue Jun 27, 2016
chadhietala added a commit to chadhietala/TypeScript-TmLanguage that referenced this issue Jun 27, 2016
@sheetalkamat
Copy link
Member

Fixed by #257

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants