Nightlies broken

[orta]

I wonder if npm install --save "typescript@next" --force is not actually updating the typescript version - or something was merged 14 days ago (feb 15th) - because this is failing inside TypeScript

 - Creating release folder
> npm run release {"cwd":"monaco-editor"}
/home/runner/work/TypeScript-Make-Monaco-Builds/TypeScript-Make-Monaco-Builds/monaco-editor/node_modules/typescript/lib/typescript.js:7691
        var index = path.indexOf("\\");
                         ^
TypeError: path.indexOf is not a function
    at normalizeSlashes (/home/runner/work/TypeScript-Make-Monaco-Builds/TypeScript-Make-Monaco-Builds/monaco-editor/node_modules/typescript/lib/typescript.js:7691:26)
    at Object.combinePaths (/home/runner/work/TypeScript-Make-Monaco-Builds/TypeScript-Make-Monaco-Builds/monaco-editor/node_modules/typescript/lib/typescript.js:7757:28)
Command Failed:
STDOUT:
> @typescript-deploys/[email protected] release
> ts-node ./build/build && ts-node ./build/release

Prod builds aren't affected - could be nodenext-y path stuff? @weswigham does this look suspicious WRT microsoft/TypeScript@67172e4

[weswigham]

Something using nightly TS hasn't been updated to the new LS module resolver API shapes. We really should add an assertion saying it's a problem with something consuming TS.

[orta]

Hah, is it because I was leaving that both monaco and typescript made breaking changes in this release to make all this infra look fragile :P

Sounds like updating monaco-editor to 4.6 is probably the next step then. The tricky bit for me here is that the prod build builds and I'd update them to stable. But then, I don't easily have a way to provide the separate version of the APIs inside monaco depending on the version - got any ideas?

[orta]

Looks like @andrewbranch fixed it with andrewbranch/monaco-editor@36fb92b