Change the conditions to switch the Google Test libraries to link #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This patch is not tested yet. I have a problem with building on VS2022. |
kazssym
changed the title
|
https://pkgs.dev.azure.com/devdiv/DevDiv/_packaging/vc-test-adapters/nuget/v3/index.json is not accessible. I hope this change has no problems for review. |
kazssym
changed the title
| @@ -16,28 +16,28 @@ | |||
| </ItemGroup> | |||
| <ItemDefinitionGroup Condition="'$(Disable-<#= PackageNameDashes #>)' == ''"> | |||
| <Link> | |||
| <AdditionalDependencies Condition="'$(Configuration)' == 'Debug' And '$(Platform)' == 'x64'">$(MSBuildThisFileDirectory)..\..\\<#= PathToBinaries #>\x64\Debug\gtestd.lib;%(AdditionalDependencies)</AdditionalDependencies> | |||
There was a problem hiding this comment.
There are runtimes errors with this patch due to mismatches detected by the linker.
kazssym
force-pushed
the
kazssym-patch-1
branch
from
d78b316
to
70bea77
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch tries to change the conditions to switch the Google Test libraries to link by using the 'Use Debug Libraries' setting of the configuration. This will make it possible to have multiple Debug configurations.