Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback requested for WPF mockup (MVVMBasic + NavigationView) #3318

Closed
sibille opened this issue Sep 17, 2019 · 4 comments
Closed

Feedback requested for WPF mockup (MVVMBasic + NavigationView) #3318

sibille opened this issue Sep 17, 2019 · 4 comments
Labels
Mockup question Indicates that the issue is an open question on how future functionality should work. WPF Relates to generated WPF projects
Milestone

Comments

@sibille
Copy link
Collaborator

sibille commented Sep 17, 2019

We'd love to hear your feedback on our first WPF mockup. You can find the solution at https://github.com/mvegaca/MyDotNetCoreWpfApp/blob/dev/MVVMBasic.sln

Project setup is the following:

ProjectType:

  • NavigationView (using Hamburger Menu)

Framework:

  • MVVMBasic

Pages:

  • Blank
  • Settings

Features:

  • MSIX Packaging
  • Theme Support (Dark/Light)
  • Setting Storage / Persisting app data

More mockups for other project types and frameworks will come soon.

@sibille sibille added question Indicates that the issue is an open question on how future functionality should work. WPF Relates to generated WPF projects labels Sep 17, 2019
@rasyidf
Copy link

rasyidf commented Sep 17, 2019

a little thought about the mockup

  1. I'm a novice programmer, but in Basic MVVM patterns, is Contracts needed, because i don't see it in the UWP template version?

  2. The UI using MahApps is a great choice. and I think, would it be nice if someone could make it look more "fluent" as in the Remote Desktop Preview application (if I'm guessing it right, its WPF). I know, this is absolutely not a priority

  3. I have so many warning when building the project, the nuget is not restoring correct framework ( Restoring Net FX 4.8 instead of .NET Core ) , is this intentional?

last thing is, a big thanks for the team effort.

@sibille
Copy link
Collaborator Author

sibille commented Sep 19, 2019

Thanks for your feedback! We're working on point 2 + 3. For 1: The reason for this is we're using dependency injection for WPF as requested by community, that's why the interfaces are needed.

@LoriBru
Copy link

LoriBru commented Oct 22, 2019

Why using MahApps instead of taking advantage of Windows UI?

@Kinnara
Copy link

Kinnara commented Nov 8, 2019

I made a fork of the mockup that uses my library ModernWPF to complement MahApps. It brings WinUI-like styling to the app while retaining the ability to use the advanced MahApps controls (e.g. HamburgerMenu). Check it out if anyone's interested.

Screenshot

@mrlacey mrlacey added this to the 3.6 milestone Nov 14, 2019
@sibille sibille modified the milestones: 3.6, 3.7 Apr 22, 2020
@sibille sibille closed this as completed May 29, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Jun 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Mockup question Indicates that the issue is an open question on how future functionality should work. WPF Relates to generated WPF projects
Projects
None yet
Development

No branches or pull requests

5 participants