Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read-AppxMetadata cmdlet should use IAppxManifestReader. #96

Open
jlaanstra opened this issue Jan 24, 2018 · 1 comment
Open

Read-AppxMetadata cmdlet should use IAppxManifestReader. #96

jlaanstra opened this issue Jan 24, 2018 · 1 comment

Comments

@jlaanstra
Copy link

Currently the Read-AppxMetadata cmdlet extract the package, any packages inside the package until it gets to the AppManifest.xml. This can take more than 5 minutes for large packages.

We should consider using IAppxManifestReader to save 5 minutes or more per build for large packages.

@HowardWolosky
Copy link
Member

There are a number of potential drawbacks to adopting IAppxManifestReader (especially given that the API currently only appears accessible via C++).

Distilling the feedback down to its root, the issue appears to be that we're extracting every single file from every single package, as opposed to just extracting the AppxManifest files (since those are all that we actually need).

So, I'd propose that we keep our existing AppxManifest property extraction logic as-is (thus, not adopting IAppxManifestReader, and instead focus on improving our file extraction logic to only extract the manifest files. That should result in a similar packaging time improvement, without the added cost of a new custom module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants