Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LWG-3949 atomic<bool>'s trivial destructor dropped in C++17 spec wording #4164

Closed
StephanTLavavej opened this issue Nov 12, 2023 · 0 comments · Fixed by #4204
Closed

LWG-3949 atomic<bool>'s trivial destructor dropped in C++17 spec wording #4164

StephanTLavavej opened this issue Nov 12, 2023 · 0 comments · Fixed by #4204
Labels
fixed Something works now, yay! LWG Library Working Group issue

Comments

@StephanTLavavej
Copy link
Member

LWG-3949 atomic<bool>'s trivial destructor dropped in C++17 spec wording

This is already implemented and tested, we just need to drop "(and bool)" from this comment:

STATIC_ASSERT(is_trivially_destructible_v<atomic<Bytes<1>>>); // these struct cases (and bool)
STATIC_ASSERT(is_trivially_destructible_v<atomic<Bytes<2>>>); // aren't technically required to work
STATIC_ASSERT(is_trivially_destructible_v<atomic<Bytes<3>>>); // in the spec, but we think they should
STATIC_ASSERT(is_trivially_destructible_v<atomic<Bytes<4>>>); // on any reasonable implementation
STATIC_ASSERT(is_trivially_destructible_v<atomic<Bytes<5>>>);
STATIC_ASSERT(is_trivially_destructible_v<atomic<Bytes<6>>>);
STATIC_ASSERT(is_trivially_destructible_v<atomic<Bytes<7>>>);
STATIC_ASSERT(is_trivially_destructible_v<atomic<Bytes<8>>>);
STATIC_ASSERT(is_trivially_destructible_v<atomic<Bytes<9>>>);
STATIC_ASSERT(is_trivially_destructible_v<atomic<bool>>);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed Something works now, yay! LWG Library Working Group issue
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant