Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LWG-3631 basic_format_arg(T&&) should use remove_cvref_t<T> throughout #3460

Closed
CaseyCarter opened this issue Feb 13, 2023 · 1 comment · Fixed by #3745
Closed

LWG-3631 basic_format_arg(T&&) should use remove_cvref_t<T> throughout #3460

CaseyCarter opened this issue Feb 13, 2023 · 1 comment · Fixed by #3745
Labels
fixed Something works now, yay! format C++20/23 format LWG Library Working Group issue

Comments

@CaseyCarter
Copy link
Member

CaseyCarter commented Feb 13, 2023 •
edited by StephanTLavavej
Loading

LWG-3631 basic_format_arg(T&&) should use remove_cvref_t<T> throughout

We have a comment indicating something is consistent with an early version of the resolution, but we need some work to implement the final resolution. (Note that we do not yet implement the formattable concept from WG21-P2286R8 #2919 "Formatting Ranges".)
@CaseyCarter CaseyCarter added the LWG Library Working Group issue label Feb 13, 2023
@CaseyCarter CaseyCarter mentioned this issue Feb 13, 2023
Closed
61 tasks
@mordante
Copy link
Contributor

Note the definition of the formattable concept in the final resolution is incorrect. See LWG 3925 for the details and the proposed fix.

@frederick-vs-ja frederick-vs-ja mentioned this issue Jun 3, 2023
Merged
@StephanTLavavej StephanTLavavej added the fixed Something works now, yay! label Jun 15, 2023
@StephanTLavavej StephanTLavavej added the format C++20/23 format label Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fixed Something works now, yay! format C++20/23 format LWG Library Working Group issue
Projects
STL LWG Issues
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement LWG-3631 basic_format_arg(T&&) should use remove_cvref_t<T> throughout frederick-vs-ja/STL
3 participants
@CaseyCarter @mordante @StephanTLavavej