Skip to content
This repository has been archived by the owner on Jan 12, 2024. It is now read-only.

Use sparse simulator for factoring #619

Merged
merged 18 commits into from
Apr 6, 2022
Merged

Use sparse simulator for factoring #619

merged 18 commits into from
Apr 6, 2022

Conversation

msoeken
Copy link
Member

@msoeken msoeken commented Mar 9, 2022

This allows to use the sparse simulator with the factoring sample. It will be used as default simulator, but the full-state simulator can be activated using a flag. The PR also contains various arithmetic operations, which can eventually be merged into the quantum libraries after API review.

@msoeken msoeken marked this pull request as ready for review March 10, 2022 13:57
@msoeken msoeken requested a review from cgranade March 10, 2022 13:57
Copy link
Contributor

@cgranade cgranade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks like a good addition, but my main concern is that it currently reads more as a library than as a sample — it'd be great if we could add more comments to help the reader understand the new operations and functions added with this PR, and about how they differ from what is currently in the library. It'd also be great to have a libraries issue we can track for adding this functionality so that we know when to remove the new functions and operations from this sample in favor of calling in to the libraries directly.

samples/algorithms/integer-factorization/Add.qs Outdated Show resolved Hide resolved
samples/algorithms/integer-factorization/Add.qs Outdated Show resolved Hide resolved
samples/algorithms/integer-factorization/Add.qs Outdated Show resolved Hide resolved
samples/algorithms/integer-factorization/Add.qs Outdated Show resolved Hide resolved
samples/algorithms/integer-factorization/Add.qs Outdated Show resolved Hide resolved
samples/algorithms/integer-factorization/Shor.qs Outdated Show resolved Hide resolved
samples/algorithms/integer-factorization/Shor.qs Outdated Show resolved Hide resolved
samples/algorithms/integer-factorization/Utils.qs Outdated Show resolved Hide resolved
samples/algorithms/integer-factorization/Utils.qs Outdated Show resolved Hide resolved
@msoeken
Copy link
Member Author

msoeken commented Mar 11, 2022

It'd also be great to have a libraries issue we can track for adding this functionality so that we know when to remove the new functions and operations from this sample in favor of calling in to the libraries directly.

Here is the corresponding issue in the library: microsoft/QuantumLibraries#423 Once this is approved we can use a lot of operations from there.

@msoeken msoeken requested a review from cgranade March 21, 2022 10:27
samples/algorithms/integer-factorization/Compare.qs Outdated Show resolved Hide resolved
samples/algorithms/integer-factorization/Compare.qs Outdated Show resolved Hide resolved
samples/algorithms/integer-factorization/Compare.qs Outdated Show resolved Hide resolved
samples/algorithms/integer-factorization/Modular.qs Outdated Show resolved Hide resolved
samples/algorithms/integer-factorization/Modular.qs Outdated Show resolved Hide resolved
samples/algorithms/integer-factorization/Program.cs Outdated Show resolved Hide resolved
samples/algorithms/integer-factorization/Shor.qs Outdated Show resolved Hide resolved
samples/algorithms/integer-factorization/Shor.qs Outdated Show resolved Hide resolved
samples/algorithms/integer-factorization/Shor.qs Outdated Show resolved Hide resolved
samples/algorithms/integer-factorization/Shor.qs Outdated Show resolved Hide resolved
@msoeken
Copy link
Member Author

msoeken commented Mar 21, 2022

@cgranade I think I caught all spelling cases. The Markdown check complains about broken links in the README file that are in the manifest and point to locations which will only be available after the merge. What is the guidance here?

@msoeken
Copy link
Member Author

msoeken commented Mar 31, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@@ -19,7 +19,8 @@
"languageId": ["qsharp"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding these!

samples/algorithms/integer-factorization/Program.cs Outdated Show resolved Hide resolved
@msoeken msoeken merged commit 807f4f4 into main Apr 6, 2022
@msoeken msoeken deleted the msoeken/factoring branch April 6, 2022 12:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants