From 2704f1c57f2fd55ad3f46fe50378b2d08a01b7f7 Mon Sep 17 00:00:00 2001 From: Heiko <61519853+htcfreek@users.noreply.github.com> Date: Sat, 20 Jan 2024 17:07:32 +0100 Subject: [PATCH 1/5] Update PowerToys.admx --- src/gpo/assets/PowerToys.admx | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/src/gpo/assets/PowerToys.admx b/src/gpo/assets/PowerToys.admx index 06757271a001..fef8e1021d87 100644 --- a/src/gpo/assets/PowerToys.admx +++ b/src/gpo/assets/PowerToys.admx @@ -451,18 +451,6 @@ - From 1e94fd97e4c3cb855d9c5ebb8c359fd0ef7fd8ef Mon Sep 17 00:00:00 2001 From: Heiko <61519853+htcfreek@users.noreply.github.com> Date: Sat, 20 Jan 2024 17:10:00 +0100 Subject: [PATCH 2/5] Update PowerToys.adml --- src/gpo/assets/en-US/PowerToys.adml | 7 ------- 1 file changed, 7 deletions(-) diff --git a/src/gpo/assets/en-US/PowerToys.adml b/src/gpo/assets/en-US/PowerToys.adml index 0fb97927af98..53d5eca86c04 100644 --- a/src/gpo/assets/en-US/PowerToys.adml +++ b/src/gpo/assets/en-US/PowerToys.adml @@ -80,12 +80,6 @@ This policy has no effect if the update notification is disabled by the policy " If enabled, the notification is disabled. If disabled or not configured, the user can control if the notification is shown or not. - - This policy allows you to disable automatic update checks running in the background. (The manual check in PT Settings is not affected by this policy.) - -If enabled, the automatic update checks are disabled. - -If disabled or not configured, the automatic update checks are enabled. This policy allows you to configure if the window with the release notes is shown after updates. @@ -165,7 +159,6 @@ Note: Changes require a restart of PowerToys Run. Do not show the release notes after updates Suspend Action Center notification for new updates Disable Action Center notification for new updates - Disable automatic update checks Allow Experimentation Configure enabled state for all plugins Configure enabled state for individual plugins From c2cd6ac15083dee0ede7ffeeb08e6f05fd584a07 Mon Sep 17 00:00:00 2001 From: Heiko <61519853+htcfreek@users.noreply.github.com> Date: Sat, 20 Jan 2024 17:12:22 +0100 Subject: [PATCH 3/5] Update UpdateUtils.cpp --- src/runner/UpdateUtils.cpp | 8 -------- 1 file changed, 8 deletions(-) diff --git a/src/runner/UpdateUtils.cpp b/src/runner/UpdateUtils.cpp index c2297e630d6a..4558b37cb3f2 100644 --- a/src/runner/UpdateUtils.cpp +++ b/src/runner/UpdateUtils.cpp @@ -200,14 +200,6 @@ void ProcessNewVersionInfo(const github_version_info& version_info, void PeriodicUpdateWorker() { - // Check if periodic update check is disabled by GPO. - // This policy code is implemented but not active. It is for later usage in PT version after 1.0 release. - //if (powertoys_gpo::getDisablePeriodicUpdateCheckValue() == powertoys_gpo::gpo_rule_configured_enabled) - //{ - // Logger::info(L"Initialization of periodic update checks stopped. Periodic update checks are disabled by GPO."); - // return; - //} - for (;;) { auto state = UpdateState::read(); From c8e22659f264baa3724094cd07e3312b869fe916 Mon Sep 17 00:00:00 2001 From: Heiko <61519853+htcfreek@users.noreply.github.com> Date: Sat, 20 Jan 2024 17:16:22 +0100 Subject: [PATCH 4/5] Update gpo.h --- src/common/utils/gpo.h | 6 ------ 1 file changed, 6 deletions(-) diff --git a/src/common/utils/gpo.h b/src/common/utils/gpo.h index 66fe34a10a9c..d1ded85f64a1 100644 --- a/src/common/utils/gpo.h +++ b/src/common/utils/gpo.h @@ -65,7 +65,6 @@ namespace powertoys_gpo { const std::wstring POLICY_DISABLE_AUTOMATIC_UPDATE_DOWNLOAD = L"AutomaticUpdateDownloadDisabled"; const std::wstring POLICY_SUSPEND_NEW_UPDATE_TOAST = L"SuspendNewUpdateAvailableToast"; const std::wstring POLICY_DISABLE_NEW_UPDATE_TOAST = L"DisableNewUpdateAvailableToast"; - const std::wstring POLICY_DISABLE_PERIODIC_UPDATE_CHECK = L"PeriodicUpdateCheckDisabled"; const std::wstring POLICY_DISABLE_SHOW_WHATS_NEW_AFTER_UPDATES = L"DoNotShowWhatsNewAfterUpdates"; // The registry value names for other PowerToys policies. @@ -412,11 +411,6 @@ namespace powertoys_gpo { return getConfiguredValue(POLICY_DISABLE_NEW_UPDATE_TOAST); } - inline gpo_rule_configured_t getDisablePeriodicUpdateCheckValue() - { - return getConfiguredValue(POLICY_DISABLE_PERIODIC_UPDATE_CHECK); - } - inline gpo_rule_configured_t getDisableShowWhatsNewAfterUpdatesValue() { return getConfiguredValue(POLICY_DISABLE_SHOW_WHATS_NEW_AFTER_UPDATES); From 17144e690b746ce4cb65af6b272cb23dfdcd5ba3 Mon Sep 17 00:00:00 2001 From: Heiko <61519853+htcfreek@users.noreply.github.com> Date: Sat, 20 Jan 2024 20:20:54 +0100 Subject: [PATCH 5/5] Update ReportGPOValues.cpp --- tools/BugReportTool/BugReportTool/ReportGPOValues.cpp | 2 -- 1 file changed, 2 deletions(-) diff --git a/tools/BugReportTool/BugReportTool/ReportGPOValues.cpp b/tools/BugReportTool/BugReportTool/ReportGPOValues.cpp index 5ca46b1b26bb..8209a28de4fe 100644 --- a/tools/BugReportTool/BugReportTool/ReportGPOValues.cpp +++ b/tools/BugReportTool/BugReportTool/ReportGPOValues.cpp @@ -62,9 +62,7 @@ void ReportGPOValues(const std::filesystem::path& tmpDir) report << "getConfiguredVideoConferenceMuteEnabledValue: " << gpo_rule_configured_to_string(powertoys_gpo::getConfiguredVideoConferenceMuteEnabledValue()) << std::endl; report << "getDisableAutomaticUpdateDownloadValue: " << gpo_rule_configured_to_string(powertoys_gpo::getDisableAutomaticUpdateDownloadValue()) << std::endl; report << "getSuspendNewUpdateToastValue: " << gpo_rule_configured_to_string(powertoys_gpo::getSuspendNewUpdateToastValue()) << std::endl; - report << "getDisablePeriodicUpdateCheckValue: " << gpo_rule_configured_to_string(powertoys_gpo::getDisablePeriodicUpdateCheckValue()) << std::endl; report << "getAllowExperimentationValue: " << gpo_rule_configured_to_string(powertoys_gpo::getAllowExperimentationValue()) << std::endl; report << "getConfiguredQoiPreviewEnabledValue: " << gpo_rule_configured_to_string(powertoys_gpo::getConfiguredQoiPreviewEnabledValue()) << std::endl; report << "getConfiguredQoiThumbnailsEnabledValue: " << gpo_rule_configured_to_string(powertoys_gpo::getConfiguredQoiThumbnailsEnabledValue()) << std::endl; - }