Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be able to dismiss installer notification #6941

Closed
scottrudy opened this issue Oct 1, 2020 · 9 comments
Closed

Be able to dismiss installer notification #6941

scottrudy opened this issue Oct 1, 2020 · 9 comments
Assignees
Labels
Area-Setup/Install Refers to installation mechanism Cost-Medium Medium work item - 1-3 Days worth of work. Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.

Comments

@scottrudy
Copy link

scottrudy commented Oct 1, 2020

📝 Do not use a toast for install status progress, perhaps show it in the MSI dialog

What is the expected behavior of the proposed feature? What is the scenario this would be used?
I would like to be able to access my notification tray icon menus, but I can't because the toast is on top and hides the menus. I also like to see progress, so I am suggesting that the status still be shown,, just not in a toast popup, as it is a bad user experience on Windows. See example below where the hidden icons in the notification tray area can't be accessed.

image


If you'd like to see this feature implemented, add a 👍 reaction to this post.

@ghost ghost added the Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams label Oct 1, 2020
@Jay-o-Way
Copy link
Collaborator

Jay-o-Way commented Oct 2, 2020

The Z-index is also mentioned in #85. As for the solution; do you have a suggestion? The current update method creates a window that shows the process too.
Also, "as it is a bad user experience" sounds like a personal opinion. Maybe you could use the Feedback hub to send a message to Microsoft, if you haven't already?

@scottrudy
Copy link
Author

scottrudy commented Oct 2, 2020

@Jay-o-Way Considering there is a Winforms dialog too, I don't see the point of the toast. I think the progress could just be shown there. I mentioned the toast to Clint via Twitter during the last release and he suggested I post an issue here.

I agree with the general issue about Windows putting notifications so close to the task bar and the z-index problem, but a progress bar, to me is not what a toast notification should be used for. They should be short lived.

@scottrudy
Copy link
Author

Here's another suggestion if you must have a toast with a progress bar. Hide/Minimize it after it displays for a few seconds. The last install I ran there was a problem with the uninstall, so that toast remained there for minutes, not seconds.

@Jay-o-Way
Copy link
Collaborator

Jay-o-Way commented Oct 2, 2020

I do not disagree with you. I've seen a few other issues (closed in the mean time) about the amount of toasts from Powertoys and their position in general. Aside from position, they can be tweaked/drawn in a few ways. I personally don't mind one or two of them, as long as they will be cleaned up when they are no longer needed.

@niels9001
Copy link
Contributor

#6751 could be a nice place for the update progress to show.

@crutkas
Copy link
Member

crutkas commented Oct 6, 2020

@niels9001, the installer then would have the flyout :)

@scottrudy you can close out / dismiss notifications. Here is the X for installing. I can install a lower version and then try 0.23 again but you should be able to X it as with any notification.
image

@crutkas crutkas added Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something Area-Setup/Install Refers to installation mechanism and removed Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams labels Oct 6, 2020
@crutkas crutkas changed the title Do not use a toast for install status progress Be able to dismiss installer notification Oct 6, 2020
@scottrudy
Copy link
Author

@crutkas I didn't have the x or -> to clear/minimize the last time I ran it, but I did have a general problem with the installer, so maybe something else was going on with my machine (e.g. explorer.exe crapping out). I'll keep an eye out next install. I do still maintain that a toast is odd place for a progress bar that doesn't hide itself after a few seconds, especially considering there is a separate installer window already.

@ghost ghost added Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams Needs-Team-Response An issue author responded so the team needs to follow up and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Oct 6, 2020
@yuyoyuppe yuyoyuppe self-assigned this Oct 15, 2020
@yuyoyuppe
Copy link
Contributor

We've got many requests to remove toast as an update progress bar, so we'll replace it with something else.

@yuyoyuppe yuyoyuppe added Cost-Medium Medium work item - 1-3 Days worth of work. and removed Needs-Team-Response An issue author responded so the team needs to follow up Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams labels Oct 15, 2020
@yuyoyuppe yuyoyuppe added the Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. label Nov 26, 2020
@crutkas
Copy link
Member

crutkas commented Dec 29, 2020

Fixed with 0.29, released today. https://github.com/microsoft/PowerToys/releases/tag/v0.29.0

@crutkas crutkas closed this as completed Dec 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Setup/Install Refers to installation mechanism Cost-Medium Medium work item - 1-3 Days worth of work. Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Development

No branches or pull requests

5 participants