[Run] Selection Colour Enhancement

[samwdp]

Environment

PowerToys version: 0.18.2

Steps to reproduce

Navigate output menu with keyboard you get a fill of 4B4948
General Colour of the output is 484848
Mouse hover colour is 5A5A5A

Expected behavior

Make the highlighted color when navigating with a keyboard the same as the color when navigating with a mouse. This makes it incredibly difficult to see which item has been selected when using a keyboard

Actual behavior

There are 3 different colours being output depending on the instance

Screenshots

[saahmedm]

Need to verify this in master, due to code changes

[niels9001]

I think we are using the Accent color brush for the selected color (= focus).

@samwdp What accent color are you using?

[samwdp]

@niels9001 I haven't changed any colours. This is the default behaviour

[samwdp]

I think we are using the Accent color brush for the selected color (= focus).

@samwdp What accent color are you using?

unless you mean Windows accent colour: here are my settings

[niels9001]

@samwdp Thanks, that helps.

@somil55 @crutkas It seems that when using a dark/grey accent color contrast is too low. That makes sense, since we are using a rectangle/border with the AccentColor with only 0.3 opacity. Removing the opacity makes the selection too bright, and will cause interference with the secondary text. In UWP we can get other variants of the selected accent color that are darker, and would be ideal as the accent color. We can then set the opacity back to 1. @somil55 Do you know if we can get to these colors with rhe new 'thememanger' library?

[dsrivastavv]

@niels9001 We can get current system accent colors using controlzex but I don't think we would be able to get other darker variants of the selected accent color.

[niels9001]

Hmm, so you don't think we could get: https://docs.microsoft.com/en-us/windows/uwp/design/style/color#accent-color-palette

SystemAccentColorLight3

SystemAccentColorLight2

SystemAccentColorLight1

SystemAccentColorDark1

SystemAccentColorDark2

SystemAccentColorDark3

[dsrivastavv]

@niels9001 I don't think that we would be able to get these colors. Controlzex is dependent on registry keys for fetching personalization information. I couldn't find any reg key that we could utilize for getting different shades for an accent. The following articles sum up all the information that could be found in the registry regarding personalization: https://superuser.com/questions/1245923/registry-keys-to-change-personalization-settings

[seppestas]

This seems to have gotten worse in v0.27.1. The selection in dark mode is now barely visible due to low contrast:

In light mode it's better:

My windows color preferences is dark mode, automatic accent color from default windows background, accent color on "Start, task bar and action center" disabled, accent color on "Title bar and window borders" enabled.

[crutkas]

@niels9001 one thing is the accent color in PT Run doesn't update on change, other thing is here is it with orange

[crutkas]

Issue I just called out is update on change is tracked by #4107