Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard Manager remaps don't work consistently with FZ and other modules #3079

Closed
arjunbalgovind opened this issue May 15, 2020 · 17 comments
Closed
Labels
Cost-Large Large work item - 3+ days worth of work (chances are needs to be broken down) Product-FancyZones Refers to the FancyZones PowerToy Product-Keyboard Shortcut Manager Issues regarding Keyboard Shortcut Manager Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.

Comments

@arjunbalgovind
Copy link
Contributor

KBM currently does not always work consistenly with FZ and Shortcut guide if the Win key is remapped. The current workaround for a user would be to disable and enable KBM (since this will restart the hook), however we should automatically do this for v1.

@arjunbalgovind arjunbalgovind added the Product-Keyboard Shortcut Manager Issues regarding Keyboard Shortcut Manager label May 15, 2020
@arjunbalgovind arjunbalgovind added this to the v1.0 Release milestone May 15, 2020
@arjunbalgovind arjunbalgovind mentioned this issue May 15, 2020
3 tasks
@saahmedm saahmedm added the Priority-1 Bug that is high priority label May 29, 2020
@arjunbalgovind
Copy link
Contributor Author

Also applies to all the other PowerToys that use low level hooks i.e. PT Run, Color Picker and any future ones.

@arjunbalgovind arjunbalgovind self-assigned this Aug 6, 2020
@saahmedm saahmedm modified the milestones: InVEST-2008, InVEST-2009 Aug 25, 2020
@arjunbalgovind
Copy link
Contributor Author

Fixing this would also fix #4205 and #4360

@crutkas
Copy link
Member

crutkas commented Sep 8, 2020

Wouldn't the #6060 work help correct this issue. @enricogior as FYI

@arjunbalgovind
Copy link
Contributor Author

It won't since KBM and SG wouldn't be running out of the centralized handler. Since these still have independent hooks we need to ensure that the KBM hook is restarted whenever any of them gets enabled.
As @yuyoyuppe suggested offline in a mail thread, using IPC would be the best way to do this.

@saahmedm saahmedm added the Priority-3 Bug that is low priority label Sep 11, 2020
@saahmedm saahmedm modified the milestones: InVEST-2009, InVEST-2010 Sep 14, 2020
@enricogior enricogior added the Product-FancyZones Refers to the FancyZones PowerToy label Jan 14, 2021
@enricogior enricogior changed the title Keyboard Manager remaps don't work consistently with FZ and Shortcut Guide Keyboard Manager remaps don't work consistently with FZ and other modules Jan 14, 2021
@dedavis6797
Copy link
Contributor

@jaimecbernardo this appears to be a large work item. Can we investigate the remaining work for this in 0.47? We don't have to try to resolve this by 0.47, I'd just like a better understanding of the timeline since this keeps getting bumped.

@jaimecbernardo
Copy link
Collaborator

@dedavis6797 ,

I've tried replicating this but without success. I've remapped the Win key and then tried to use the shortcuts for FancyZones and Shortcut Guide without success (as expected).

So what's the issue here? It might have been fixed given all the changes in KBM, FancyZones and Shortcut Guide since then. Opened issues relating to this issue seem to have been closed since then as well.

@arjunbalgovind , how can we replicate this?

@jaimecbernardo jaimecbernardo added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Aug 6, 2021
@ghost ghost added the Status-No recent activity no activity in the past 5 days when follow up's are needed label Aug 11, 2021
@ghost
Copy link

ghost commented Aug 11, 2021

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 5 days. It will be closed if no further activity occurs within 5 days of this comment.

@arjunbalgovind
Copy link
Contributor Author

arjunbalgovind commented Aug 11, 2021

@jaimecbernardo I'm not able to repro this anymore. This used to happen when all the keyboard hooks used to run from the main runner process. Seems like this was fixed as a result of #10127 probably since it runs at a higher priority. I think the issue can be closed.

@ghost ghost added Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams Needs-Team-Response An issue author responded so the team needs to follow up and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something Status-No recent activity no activity in the past 5 days when follow up's are needed labels Aug 11, 2021
@jaimecbernardo
Copy link
Collaborator

Thank you!

@jaimecbernardo jaimecbernardo added Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed Needs-Team-Response An issue author responded so the team needs to follow up Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams labels Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cost-Large Large work item - 3+ days worth of work (chances are needs to be broken down) Product-FancyZones Refers to the FancyZones PowerToy Product-Keyboard Shortcut Manager Issues regarding Keyboard Shortcut Manager Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Development

No branches or pull requests

8 participants