-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keyboard Manager remaps don't work consistently with FZ and other modules #3079
Comments
Also applies to all the other PowerToys that use low level hooks i.e. PT Run, Color Picker and any future ones. |
Wouldn't the #6060 work help correct this issue. @enricogior as FYI |
It won't since KBM and SG wouldn't be running out of the centralized handler. Since these still have independent hooks we need to ensure that the KBM hook is restarted whenever any of them gets enabled. |
@jaimecbernardo this appears to be a large work item. Can we investigate the remaining work for this in 0.47? We don't have to try to resolve this by 0.47, I'd just like a better understanding of the timeline since this keeps getting bumped. |
I've tried replicating this but without success. I've remapped the Win key and then tried to use the shortcuts for FancyZones and Shortcut Guide without success (as expected). So what's the issue here? It might have been fixed given all the changes in KBM, FancyZones and Shortcut Guide since then. Opened issues relating to this issue seem to have been closed since then as well. @arjunbalgovind , how can we replicate this? |
This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 5 days. It will be closed if no further activity occurs within 5 days of this comment. |
@jaimecbernardo I'm not able to repro this anymore. This used to happen when all the keyboard hooks used to run from the main runner process. Seems like this was fixed as a result of #10127 probably since it runs at a higher priority. I think the issue can be closed. |
Thank you! |
KBM currently does not always work consistenly with FZ and Shortcut guide if the Win key is remapped. The current workaround for a user would be to disable and enable KBM (since this will restart the hook), however we should automatically do this for v1.
The text was updated successfully, but these errors were encountered: