Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Color Picker] memory leak #24047

Closed
smfukaya opened this issue Feb 10, 2023 · 14 comments
Closed

[Color Picker] memory leak #24047

smfukaya opened this issue Feb 10, 2023 · 14 comments
Assignees
@stefansjfw
Labels
Issue-Bug Something isn't working Priority-0 Bugs that we consider release-blocking/recall-class (P0) Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. Severity-High Bugs that we consider a blocking issue for release (crashes stuff outside of PT)

Comments

@smfukaya
Copy link

smfukaya commented Feb 10, 2023 •
edited
Loading

Microsoft PowerToys version

0.67.1

Installation method

GitHub

Running as admin

No

Area(s) with issue?

ColorPicker

Steps to reproduce

Don't know how to reproduce the problem, but I issued the combination key WIN + SHIFT + C and the Color Pick UI didn't show up.
PowerToysReport_2023-02-10-14-55-17.zip

✔️ Expected Behavior

Color Pick UI be displayed.

❌ Actual Behavior

Color Pick UI was not displayed and "PowerToys.ColorPickerUI.exe" was consuming around 14 GB of RAM.

Other Software

No response
@smfukaya smfukaya added Issue-Bug Something isn't working Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams labels Feb 10, 2023
@crutkas
Copy link
Member

crutkas commented Feb 10, 2023

A dump file could be very helpful here

@crutkas
Copy link
Member

crutkas commented Feb 10, 2023

@jaimecbernardo fyi

@budderball29
Copy link

a very similar thing happened to me though not related to color picker, after leaving powertoys open and the system on for about 8 hours PowerToys.PowerLauncher.exe was using about 2/3 of system memory alone (20GB/32GB) i have a dump file made in process explorer but i am not experienced enough to understand the problem and the dmp file itself is 15GB

@jaimecbernardo
Copy link
Collaborator

@budderball29 , can we please get a bug report as well?

@jaimecbernardo
Copy link
Collaborator

On @smfukaya 's bug report, it seems there's some sort of loop going on. Looks like there's some event loop trying to send telemetry from Color Picker in the 2023-02-09 logs.

@jaimecbernardo jaimecbernardo added Priority-0 Bugs that we consider release-blocking/recall-class (P0) Severity-High Bugs that we consider a blocking issue for release (crashes stuff outside of PT) and removed Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams labels Feb 13, 2023
@Jay-o-Way Jay-o-Way moved this to To do in Test for PowerToys Feb 14, 2023
@Jay-o-Way Jay-o-Way mentioned this issue Mar 1, 2023
Merged
@sosssego
Copy link
Contributor

sosssego commented Mar 2, 2023

@smfukaya @budderball29
Did it happen multiple times? Or only once?

@smfukaya
Copy link
Author

smfukaya commented Mar 2, 2023

Hi @sosssego

It happened just that time.

@bloodyeyesblackblood
Copy link

bloodyeyesblackblood commented Apr 29, 2023 •
edited
Loading

same happened to me, worked again after changing shortcut and disable/re-enablin' it.. also 60 - 130mb Memory usage.. :).. but 14GB? holy..

@Juraj-Masiar
Copy link

Juraj-Masiar commented May 17, 2023 •
edited
Loading

I use color picker only rarely and currently it's taking 500MB RAM:

image

And it's not even opened.

EDIT:
I have a full memory dump (1GB, 200MB zipped) that I can share with someone if needed.

@crutkas crutkas mentioned this issue May 18, 2023
Closed
@visitorhub
Copy link

Hi Team,

I've also seen this - can provide DMPs.

Could someone please DM me a location for the upload (all files are around 3 GBs).

Thank you

@crutkas
Copy link
Member

crutkas commented May 22, 2023

honestly, the best way would be hand this off via Windows Feedback hub.

In category do "Apps" and select PowerToys.

From there you should be able to attach a file. This would be the best way i believe as then stuff routed through correct systems as dmps can hold PII data.

@Juraj-Masiar
Copy link

Done, here is my report with zipped dump attached:
https://aka.ms/AAkwx14

@stefansjfw stefansjfw mentioned this issue May 25, 2023
Merged
11 tasks
@stefansjfw stefansjfw added the Status-In progress This issue or work-item is under development label May 25, 2023
@stefansjfw stefansjfw self-assigned this May 25, 2023
@visitorhub
Copy link

Hi Team,

Just uploaded 3 out of 4 DMPs via Feedback Hub, the 4th one is 2 GBs and was not accepted - although the Feedback Hub did not display any error.

Should you also need the 4th Dump, please let me know if I can provide you a public link for it and the password via DM / email.

Thank you

@jaimecbernardo jaimecbernardo added Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed Status-In progress This issue or work-item is under development labels May 30, 2023
@dtaylor84 dtaylor84 mentioned this issue Jun 13, 2023
Closed
@jaimecbernardo jaimecbernardo mentioned this issue Jun 20, 2023
Closed
@crutkas
Copy link
Member

crutkas commented Jul 14, 2023

Fixed in 0.71 release of PowerToys. aka.ms/installpowertoys

@crutkas crutkas closed this as completed Jul 14, 2023
@github-project-automation github-project-automation bot moved this from To do to Done ✔ in Test for PowerToys Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stefansjfw stefansjfw

Labels
Issue-Bug Something isn't working Priority-0 Bugs that we consider release-blocking/recall-class (P0) Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. Severity-High Bugs that we consider a blocking issue for release (crashes stuff outside of PT)
Projects
Test for PowerToys
Status: Done ✔
Milestone
No milestone
Development

No branches or pull requests
9 participants
@crutkas @Juraj-Masiar @sosssego @jaimecbernardo @smfukaya @visitorhub @stefansjfw @budderball29 @bloodyeyesblackblood