Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FancyZones] ZoneWindow concurrency issues #2105

Closed
ivan100sic opened this issue Apr 13, 2020 · 2 comments
Closed

[FancyZones] ZoneWindow concurrency issues #2105

ivan100sic opened this issue Apr 13, 2020 · 2 comments
Assignees
@ivan100sic
Labels
Issue-Bug Something isn't working Product-FancyZones Refers to the FancyZones PowerToy Resolution-Already Fixed/Doesn't Apply A change in the product has made the issue obsolete.

Comments

@ivan100sic
Copy link
Contributor

ZoneWindow class is accessed concurrently, but it does not have a mutex. This could cause crashes or other unexpected behavior.

Environment

Windows build number: Microsoft Windows [Version 10.0.18363.720]
PowerToys version: 77e49844683fb66d99114b2af5311ab3051a4eff
PowerToy module for which you are reporting the bug (if applicable): FancyZones

Steps to reproduce

Sometimes (although very rarely) dragging a window around before snapping to a zone causes a crash. This has been traced back to a concurrency issue in the ZoneWindow class.

Expected behavior

No crashes or other unexpected behavior, ZoneWindow should have a mutex to protect data which is accessed concurrently.

Actual behavior

See above.
@ivan100sic ivan100sic added Issue-Bug Something isn't working Product-FancyZones Refers to the FancyZones PowerToy labels Apr 13, 2020
@ivan100sic ivan100sic self-assigned this Apr 15, 2020
@ivan100sic ivan100sic mentioned this issue Apr 16, 2020
Merged
3 tasks
@enricogior enricogior added the Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. label Apr 20, 2020
@enricogior enricogior removed the Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. label Apr 28, 2020
@enricogior enricogior changed the title FancyZones, ZoneWindow concurrency issues [FancyZones] ZoneWindow concurrency issues Apr 29, 2020
@crutkas
Copy link
Member

crutkas commented May 19, 2020

What is the status here. There was a merge but fix commuted was removed

@enricogior enricogior added the Resolution-Already Fixed/Doesn't Apply A change in the product has made the issue obsolete. label May 19, 2020
@enricogior
Copy link
Contributor

The original fix was rolled back and we ended up fixing this with multiple PRs that change the underline code significantly.

@snyk-bot snyk-bot mentioned this issue Sep 13, 2021
Open
@snyk-bot snyk-bot mentioned this issue Sep 23, 2021
Open
@Itchibon777 Itchibon777 mentioned this issue Jun 20, 2022
Open
@snyk-bot snyk-bot mentioned this issue May 9, 2023
Open
@Itchibon777 Itchibon777 mentioned this issue Jul 4, 2023
Open
@Itchibon777 Itchibon777 mentioned this issue Oct 28, 2023
Open
This was referenced Nov 27, 2023
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ivan100sic ivan100sic

Labels
Issue-Bug Something isn't working Product-FancyZones Refers to the FancyZones PowerToy Resolution-Already Fixed/Doesn't Apply A change in the product has made the issue obsolete.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@crutkas @enricogior @ivan100sic