Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More Quick Accent characters please #20390

Closed
wigster opened this issue Sep 8, 2022 · 22 comments
Closed

More Quick Accent characters please #20390

wigster opened this issue Sep 8, 2022 · 22 comments
Assignees
Labels
Idea-Enhancement New feature or request on an existing product Product-Quick Accent Refers to the Quick Accent PowerToy Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. Status-In progress This issue or work-item is under development

Comments

@wigster
Copy link

wigster commented Sep 8, 2022

Description of the new feature / enhancement

Quick Accent is a Godsend for my "English writer in Slavic country" situation -- so thanks! But the selection of characters available seems a little inconsistent (in terms of from which language they come) and insufficiently wide.

For example, the Polish ń ć ś are there, but the ą ę ł ż ź are not.
The Czech č š are there, but not the ž ř ě ů, ť ď
Indeed no r z d t modifiers are present at all.

It would be great if this could be made more complete.

Scenario when this would be used?

My typical usecase -- I am writing in English with the US/UK (intl) layout, but need to include the random accented character in a place name or surname. Currently I switch the keyboard layout to eg. Czech and then Polish when am dealing with both, and in the mean time upset the spellchecker than I am not writing in a different language. Quick Accent allows me to continue with the English layout, just entering the extra accent.

Probably there is no space to have all the Unicode accents for every language (or maybe there is?), but having the characters at least complete by language would be great so that if I need a particular language for some local words (eg Romanian, Czech, Polish) I don't need to keep local keyboard layout at all.

Supporting information

No response

@wigster wigster added the Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams label Sep 8, 2022
@Jay-o-Way Jay-o-Way added Idea-Enhancement New feature or request on an existing product Product-Quick Accent Refers to the Quick Accent PowerToy and removed Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams labels Sep 9, 2022
@stephtr
Copy link

stephtr commented Sep 9, 2022

There are also other symbols I would love to see in Quick Accent, like en- and em-dashes 🙂
Adding greek letters would, at least for me, also useful.

@htcfreek
Copy link
Collaborator

can work on this

@htcfreek htcfreek self-assigned this Sep 10, 2022
@Aaron-Junker Aaron-Junker added the Status-In progress This issue or work-item is under development label Sep 12, 2022
@Aaron-Junker
Copy link
Collaborator

@Jay-o-Way Why did you assign me?

@Jay-o-Way
Copy link
Collaborator

The dashes you made a pr for, but you're right, that's not this issue :)

@htcfreek
Copy link
Collaborator

@Aaron-Junker
I did never says that this is in progress. It's only assigned to me. But work hasn't started so far.

@Aaron-Junker Aaron-Junker removed the Status-In progress This issue or work-item is under development label Sep 13, 2022
@htcfreek
Copy link
Collaborator

I am a bit busy at the moment. So if someone else wants to implement it feel free to do so.

cc: @Aaron-Junker , @Jay-o-Way , @stefansjfw

@stefansjfw
Copy link
Collaborator

ref #20608

@damienleroy
Copy link
Collaborator

In PowerAccent I implemented the possibility to choose by Country.
And Friday I have a day off. So I will have some time to propose my MR in PowerToys. If you are OK with this feature.
(here it means add a dropdown in the settings with the list of countries).

@damienleroy
Copy link
Collaborator

Here the list of countries currently implemented in PowerAccent:
https://github.com/damienleroy/PowerAccent/blob/main/PowerAccent.Core/Languages.cs#L24-L34

@Aaron-Junker
Copy link
Collaborator

@damienleroy What's the exact idea behind this? Don't you normally have all the accent keys already on your keyboard for languages you write for?
And if not it is normally an exceprion and you can then use PowerAccent. Or how do you see this?

@damienleroy
Copy link
Collaborator

damienleroy commented Sep 21, 2022

The idea is to not "override" accents from others we don't need. Ex: I am a French guy with a QWERTY keyboard, I don't really care about others accents not frenchies. It makes more complicate/longer the selection of the accent you want to stroke.
People can even choose ALL if they need. Giving all the accents possible:
https://github.com/damienleroy/PowerAccent/blob/main/PowerAccent.Core/Languages.cs#L46

But I can understand if with PT you want do it in an another way. So the ALL accent selection would be enough. You can see there is a lot :)

@stephtr
Copy link

stephtr commented Sep 21, 2022

Either this or that it just has an influence on the order the different proposed letters are presented.

@crutkas
Copy link
Member

crutkas commented Sep 21, 2022

@damienleroy i think that is a great idea. Please open a PR.

@htcfreek
Copy link
Collaborator

I agree with @crutkas. After implantation we should check which other issues are closed with the solution and which ones are not because of missing language or letters.

@pjfayer
Copy link

pjfayer commented Sep 21, 2022

I'm sorry, but I think you're on the wrong track (or at least an incomplete one). Ok, quick set-up for different languages is a nice touch, but you will never satisfy everyone with this approach. Please allow for a "Custom" entry as well, where we can add whatever characters, in whatever order we want to use.

@crutkas
Copy link
Member

crutkas commented Sep 21, 2022

My thought here is let's do a possible solution and get some feedback. I agree with the concept of a custom profile is a good idea.

My belief is forward movement which gain wider language support is better than nothing for a few releases.

@damienleroy
Copy link
Collaborator

damienleroy commented Sep 23, 2022

Here the PR #20798
Tried to add the possibility to disable the tool when gamemode is activated. But it seems more complicated as plan (need a bit more time). So for now I commented it. The ask was from damienleroy/PowerAccent#34

For the selection of all accents, I put All as text. May be something like World Wide or something similar could be better to the user experience. What do you think?

@htcfreek
Copy link
Collaborator

Here the PR #20798
(...)
For the selection of all accents, I put All as text. May be something like World Wide or something similar could be better to the user experience. What do you think?

I think something like "All available counties" is a good idea.

@Kingjames52-bot
Copy link

Maybe all available (state)

@htcfreek htcfreek removed their assignment Sep 25, 2022
@htcfreek htcfreek added the Status-In progress This issue or work-item is under development label Sep 25, 2022
@Jay-o-Way
Copy link
Collaborator

I'm curious what the UI will be

@wigster
Copy link
Author

wigster commented Oct 5, 2022

I've just installed 0.63 with the language choices -- the new characters are great, but now there are many. Could we make it possible to choose multiple languages (but not all). The problem I am trying to solve is entering the odd character from a list of 3-4 languages I deal with when my main keyboard it not set to that language.

For the moment I am keeping all languages, but the lists can be a bit long... Having on language is not enough for me.

@damienleroy
Copy link
Collaborator

It is something we need to think. Currently it is not on the way. Multiselection causing some trouble about the orders we will need to display them.

@taras-janea taras-janea added the Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. label Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Idea-Enhancement New feature or request on an existing product Product-Quick Accent Refers to the Quick Accent PowerToy Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. Status-In progress This issue or work-item is under development
Projects
None yet
Development

No branches or pull requests