"Restore the original size of windows when unsnapping" doesn't quite restore original size

[NeoNavras]

Microsoft PowerToys version

0.57.0

Running as admin

• Yes

Area(s) with issue?

FancyZones

Steps to reproduce

1. Enable "Restore the original size of windows when unsnapping"
2. Have a display scaling other than 100% set (e.g. 125%) [added this step after edit]
3. Repeatably Snap and Unsnap a Window

3440x1440 monitor with 3 (equal-width) column zones.

✔️ Expected Behavior

Restore original size on unsnap.

❌ Actual Behavior

With each unsnap the "Original Aspect Ratio" seems to be restored but the area of the window gets smaller.

Video evidence: https://youtu.be/ujQYvWHXqJ4

Other Software

No response

[Jay-o-Way]

What is your display scale setting? My first guess would be that the scaling of the display is not applied when unsnapping.
CC: @SeraphimaZykova

[NeoNavras]

I have it set to 125%. When I set it to 100% the problem doesn't happen indeed. Not a great workaround, as everything becomes too small for my taste; but this narrowed down the cause.

[Jay-o-Way]

Yep, this is a bug with scaling. Can reproduce.
Seraphima: I'm guessing the bug is somewhere in file WindowUtils.cpp -> in method FancyZonesWindowUtils::SaveWindowSizeAndOrigin or RestoreWindowSize. Am I close? 😇

P.S. (extra) should the third parameter in L 382 & 384 memcpy(...) not be sizeof windowSizeData, since rawData is still empty?

[NeoNavras]

Thanks for your source code digging :) Let's hope it can be resolved soon.

Another bug I suppose that is keeping me from using the "Restore the original size of windows when unsnapping" option (toggled with the bool restoreSize according to the source code) is the one from here #9464 In WindowMoveHandler.cpp I found the lines 240-242 which kind of read like they should solve that issue (resizing a snaped window unsnaps it, so it won't be restored to the pre-snaped-size once you drag it again), but apparently they don't, and I couldn't figure out what the lines actually do, or where else to intercept the logic in order to get the desired behaviour described in #9464

[NeoNavras]

Hotfix Release 0.57.2 solved it :) Thanks for super fast resolution!

[jaimecbernardo]

Reopening until we do the next major release.