Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PowerToys Run calculator comma issues #15251

Closed
1 task
Matszwe02 opened this issue Jan 4, 2022 · 5 comments
Closed
1 task

PowerToys Run calculator comma issues #15251

Matszwe02 opened this issue Jan 4, 2022 · 5 comments
Labels
Issue-Bug Something isn't working Product-PowerToys Run Improved app launch PT Run (Win+R) Window Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. Run-Plugin Things that relate with PowerToys Run's plugin interface

Comments

@Matszwe02
Copy link

Matszwe02 commented Jan 4, 2022

Microsoft PowerToys version

0.51.1

Running as admin

  • Yes

Area(s) with issue?

PowerToys Run

Steps to reproduce

Using calculator with comma or period gives incorrect results depending of default system's calculator floating-number symbol

✔️ Expected Behavior

comma and period treated the same way

❌ Actual Behavior

When I have default "," in my system calculator, typing "," gives a proper result, but when typing "." , PowerToys cuts all leading zeros after the sign

"0,1 * 0,001 = 0,0001" ✔
"0.1 * 0.001 = 0,01" ❌

image

Other Software

No response

@Matszwe02 Matszwe02 added Issue-Bug Something isn't working Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams labels Jan 4, 2022
@franky920920
Copy link
Contributor

Duplicate of #13562

@franky920920 franky920920 marked this as a duplicate of #13562 Jan 4, 2022
@franky920920
Copy link
Contributor

Thanks for reporting this. This issue is a duplicate.
I'm linking this issue to #13562 to centralize the discussion thread for tracking.

Thanks for your help to make PowerToys a better piece of software!

@franky920920 franky920920 added Product-PowerToys Run Improved app launch PT Run (Win+R) Window Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. Run-Plugin Things that relate with PowerToys Run's plugin interface labels Jan 4, 2022
@crutkas
Copy link
Member

crutkas commented Jan 4, 2022

comma and a period can't be treated the same way is the issue for the exact reason you kind of outlined. I think #13562 would be a good spot but like, for EN-US and if i pasted in the number 1,000.23, my number shouldn't be 1.00023, it should be 1000.23 as EN-US has commas be the thousand delimiter.

@crutkas crutkas closed this as completed Jan 4, 2022
@crutkas crutkas removed the Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams label Jan 4, 2022
@Jay-o-Way Jay-o-Way marked this as not a duplicate of #13562 Mar 10, 2022
@Jay-o-Way
Copy link
Collaborator

Jay-o-Way commented Mar 10, 2022

@crutkas

the issue here is NOT in the decimal character, because that IS recognised. The problem is that leading zeros for the fracture part are trimmed off before the calculation. Please tell me you see the difference?

#2265 might solve this too, but I really want to stress the difference. And since that issue does not mention the problem of the zeros, I am not marking this as duplicate for that issue.

@Jay-o-Way
Copy link
Collaborator

Duplicate of #12375

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug Something isn't working Product-PowerToys Run Improved app launch PT Run (Win+R) Window Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. Run-Plugin Things that relate with PowerToys Run's plugin interface
Projects
None yet
Development

No branches or pull requests

4 participants