Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unifiying MVVM and usage patterns #1083

Closed
crutkas opened this issue Jan 13, 2020 · 6 comments
Closed

Unifiying MVVM and usage patterns #1083

crutkas opened this issue Jan 13, 2020 · 6 comments
Labels
Area-Quality Stability, Performance, Etc. Area-User Interface things that regard UX for PowerToys
Milestone

Comments

@crutkas
Copy link
Member

crutkas commented Jan 13, 2020

As we migrate work from existing frameworks in #891, we should start thinking about unifying our MVVM pattern frameworks.

MvvmLight comes to mind

@crutkas crutkas added the Area-User Interface things that regard UX for PowerToys label Jan 13, 2020
@crutkas crutkas added this to the Backlog milestone Jan 13, 2020
@crutkas crutkas added the Area-Quality Stability, Performance, Etc. label Jan 21, 2020
@Sergio0694
Copy link
Member

Hey @crutkas, was just about to open an issue about this but I'll just comment here then 😄

I was browsing through the codebase today and saw you're already using some packages from the Windows Community Toolkit, have you considered moving Power Toys to use the new MVVM Toolkit (aka Microsoft.Toolkit.Mvvm) package? We presented it last months at .NET Conf and released a new preview build that is available on NuGet, and the plan is for it to be officially available with the next 7.0 release of the WCT. This new package can be seen as the successor to MvvmLight and we also have some migration docs for developers coming from MvvmLight, so if you were considering that lib, the MVVM Toolkit seems like a good choice?

@michael-hawker and I will be happy to help if you have any questions about it!
Keep up the awesome work! 😊

@michael-hawker
Copy link
Contributor

The other good thing with the MVVM Toolkit is that it's .NET Standard, so since Power Toys has WPF + UWP components, you could use it to help solidify the common bits between them (if any).

@crutkas
Copy link
Member Author

crutkas commented Dec 1, 2020

We have chatted with @michael-hawker on this in the past and can see adopting this.

While we want to do it, it is a larger task and would need each item broken down. I think don't think it is an item we are prioritizing for our larger 'push to stability' push but would accept community members helping migrate.

@michael-hawker
Copy link
Contributor

Thanks @crutkas for the update. We should be shipping 7.0 in January 🤞. Would you be wanting to wait for our final release of the MVVM library or is getting started with the preview alright if someone wants to take this on?

Our API surface for the MVVM Toolkit should be pretty stable now. I don't think we expect too many radical changes outside of potentially ObservableValidator which we're trying to coordinate a bit more with the WinUI team on. Right @Sergio0694?

@Sergio0694
Copy link
Member

@michael-hawker Yup, outside of possibly some changes to ObservableValidator to improve the experience with WinUI (which should mostly just be new APIs though), I would consider the current API surface pretty stable at this point - it's the 4th preview after all 😄

In my branch for Preview 5 I mostly just have some more tweaks and minor improvements or internal optimizations, but nothing that would be breaking for consumers so far.

@crutkas
Copy link
Member Author

crutkas commented May 17, 2024

a glorious dream but i doubt we'll ever get to a unified spot

@crutkas crutkas closed this as completed May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Quality Stability, Performance, Etc. Area-User Interface things that regard UX for PowerToys
Projects
None yet
Development

No branches or pull requests

3 participants