Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set-GitHubRepositoryTeamPermission Support Custom Repository Role Name #352

Open
tbulding opened this issue May 10, 2022 · 1 comment
Open
Labels
api completeness This is basic API functionality that hasn't been implemented yet. api-repositories Work to complete the API's defined here: https://developer.github.com/v3/repos/ enhancement An issue or pull request introducing new functionality to the project. help wanted Anyone in the community is welcome to do this work up for grabs Anyone in the community is welcome to do this work

Comments

@tbulding
Copy link

Feature Idea Summary

The GitHub API for Add or update team repository permissions Supports the use of Custom Repository Roles. It would be beneficial to extend that support to this function.

Feature Idea Additional Details

Per the GH API documentation:

permission
The permission to grant the team on this repository. In addition to the enumerated values, you can also specify a custom repository role name, if the owning organization has defined any. If no permission is specified, the team's permission attribute will be used to determine what permission to grant the team on this repository.

Requested Assignment

I'm just suggesting this idea, but don't want to implement it.

Operating System

Name Value


OSVersion Unix 12.3.1
Is 64-bit True
Current culture en-US
Current UI culture en-US

PowerShell Version

Name Value


PSVersion 7.2.1
PSEdition Core
GitCommitId 7.2.1
OS Darwin 21.4.0 Darwin Kernel Version 21.4.0: Fri Mar 18 00:45:05 PDT 2022; root:xnu-8020.101.4~15/RELEASE_X86_64
Platform Unix
PSCompatibleVersions {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion 2.3
SerializationVersion 1.1.0.1
WSManStackVersion 3.0

Module Version

Running: 0.16.0
Installed: 0.16.0

@tbulding tbulding added enhancement An issue or pull request introducing new functionality to the project. triage needed An issue that needs to be reviewed by a member of the team. labels May 10, 2022
@HowardWolosky HowardWolosky added up for grabs Anyone in the community is welcome to do this work api completeness This is basic API functionality that hasn't been implemented yet. help wanted Anyone in the community is welcome to do this work api-repositories Work to complete the API's defined here: https://developer.github.com/v3/repos/ and removed triage needed An issue that needs to be reviewed by a member of the team. labels Jul 27, 2022
@HowardWolosky
Copy link
Member

Thanks for bringing this up. From what I can tell, this is a GitHub Enterprise/GitHub Cloud-only feature. It doesn't appear to be possible to create custom Roles on the public GitHub.com site, so I'm unable to test out/validate the experience. If someone who does have access to GitHub Enterprise/Cloud is interested in working on this, please reach out and let me know.

If we were to move forward with this, we'd have to look at a slight change to the Set-GitHubRepositoryTeamPermission signature to allow for a custom role to be passed-in, and we'd have to reexamine the logic used in Add-GitHubRepositoryTeamPermissionAdditionalProperties which adds the custom permission property to the object.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api completeness This is basic API functionality that hasn't been implemented yet. api-repositories Work to complete the API's defined here: https://developer.github.com/v3/repos/ enhancement An issue or pull request introducing new functionality to the project. help wanted Anyone in the community is welcome to do this work up for grabs Anyone in the community is welcome to do this work
Projects
None yet
Development

No branches or pull requests

2 participants