Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update New-GitHubRepositoryBranchProtectionRule parameters to match those of New-GitHubRepositoryBranchPatternProtectionRule #320

Open
HowardWolosky opened this issue Mar 23, 2021 · 0 comments
Labels
good first issue If you're new to the project (or to OSS in general) and you'd like to contribute, try this one. help wanted Anyone in the community is welcome to do this work technical debt Work that was postponed by a previous change. up for grabs Anyone in the community is welcome to do this work

Comments

@HowardWolosky
Copy link
Member

Feature Idea Summary

During #313, New-GitHubRepositoryBranchPatternProtectionRule was added which has a similar parameter set to New-GitHubRepositoryBranchProtectionRule, however it uses the singular case for parameter names per the [ strongly encouraged development guidelines for PowerShell] (https://docs.microsoft.com/en-us/powershell/scripting/developer/cmdlet/strongly-encouraged-development-guidelines?view=powershell-7.1#use-singular-parameter-names).

We should update the parameter names of New-GitHubRepositoryBranchPatternProtectionRule to match.

Feature Idea Additional Details

See this PR comment thread for more context.

Requested Assignment

I'm just suggesting this idea, but don't want to implement it.

Operating System

OsName               : Microsoft Windows 10 Pro
OsOperatingSystemSKU : 48
OsArchitecture       : 64-bit
WindowsVersion       : 2004
WindowsBuildLabEx    : 19041.1.amd64fre.vb_release.191206-1406
OsLanguage           : en-US
OsMuiLanguages       : {en-US}

PowerShell Version

Name                           Value
----                           -----
PSVersion                      5.1.19041.610
PSEdition                      Desktop
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   10.0.19041.610
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1

Module Version

Running: 0.16.0
Installed:
@HowardWolosky HowardWolosky added up for grabs Anyone in the community is welcome to do this work help wanted Anyone in the community is welcome to do this work technical debt Work that was postponed by a previous change. good first issue If you're new to the project (or to OSS in general) and you'd like to contribute, try this one. labels Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue If you're new to the project (or to OSS in general) and you'd like to contribute, try this one. help wanted Anyone in the community is welcome to do this work technical debt Work that was postponed by a previous change. up for grabs Anyone in the community is welcome to do this work
Projects
None yet
Development

No branches or pull requests

2 participants
@HowardWolosky and others