Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Application Insights Instrumentation Key needs to be handled separately #189

Closed
pratapladhani opened this issue Mar 19, 2021 · 2 comments
Closed
Assignees
Labels
breaking Breaking change (file format update)

Comments

@pratapladhani
Copy link

Power Apps Canvas apps allow adding an Application Insights instrumentation key as per this article.

After unpacking, currently this Instrumentation Key is part of the CanvasManifest.json file as part of the Properties Array. It would be great to have this Instrumentation Key pulled out as a separate file, so that it can be easily changed as part of the ALM CI/CD pipelines.

image

@MikeStall MikeStall added the breaking Breaking change (file format update) label Mar 19, 2021
@MikeStall MikeStall self-assigned this Mar 19, 2021
@MikeStall
Copy link
Contributor

Note that they key is not a secret.
microsoft/ApplicationInsights-JS#281

@MikeStall
Copy link
Contributor

MikeStall commented Mar 22, 2021

More on PowerApps and AppInsights:
https://docs.microsoft.com/en-us/powerapps/maker/canvas-apps/application-insights

The fix here is to split the key into its own file to make it more accessible to ALM tooling. We'll call the file AppInsightsKey.json,

{
   "InstrumentationKey" : "ABCD"
}

Also need to verify there's no other changes to the msapp the app when a key is set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking change (file format update)
Projects
None yet
Development

No branches or pull requests

3 participants