Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multiple reads of nasa-nex-gddp-cmip6 dataset from MultiZarrToZarr concatenated metadata returns all nans #289

Open
solomon-negusse opened this issue Jan 2, 2024 · 2 comments

Comments

@solomon-negusse
Copy link

Simply running twice cells 13 & 14 of the notebook that read and plot point single variable time-series for a point will reproduce this issue where the first run will have the valid values but second will be all nans. I encountered this when parallelizing reading of the files with dask that results in multiple reads and the unexpected result.

@TomAugspurger
Copy link

Thanks for the report. I won't have a chance to look into this for a while, but one note in case you want to look into it:

It looks like that's mutating a value in-place:

d["templates"][key] = d["templates"][key] + "?" + sas_token

So that cell probably isn't idempotent, and so it probably wouldn't be safe to run multiple times. I wonder what would happen if you avoid that (either by splitting the logic that updates the template, or by copy.deepcopy-ing d before running that.

@solomon-negusse
Copy link
Author

Thanks for the quick response, will test that out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants