Pylance will request PTVS to listen for "**/*" under root but we dont… #8059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… want to listen for file events in the interpreter folder. We already have conda and pip managers listening to them. This fixes the issue of deleting an "env" folder then having PTVS quickly switching to the default env folder and tells Pylance to update its interpreter settings but the previous env folder file evnets are still being triggered and after Pylance updates its config it will keep refreshing analysis due to previous env file events.
bschnurr
commented
Nov 7, 2024
| @@ -99,7 +99,7 @@ internal sealed class PythonLanguageClient : ILanguageClient, ILanguageClientCus | |||
| private static TaskCompletionSource<int> _readyTcs = new TaskCompletionSource<int>(); | |||
| private bool _loaded = false; | |||
| private Timer _deferredSettingsChangedTimer; | |||
| private const int _defaultSettingsDelayMS = 2000; | |||
| private const int _defaultSettingsDelayMS = 5000; | |||
There was a problem hiding this comment.
increasing settings delay helps delay analysis on while installing new packages
bschnurr
commented
Nov 7, 2024
Python/Product/PythonTools/PythonTools/LanguageServerClient/PythonLanguageClient.cs
Outdated
Show resolved
Hide resolved
…thonLanguageClient.cs
|
bschnurr
commented
Nov 7, 2024
| if (PathUtils.IsSubpathOf(context.RootPath, context.InterpreterConfiguration.InterpreterPath)) { | ||
| var pattern = CommonUtils.GetRelativeFilePath(context.RootPath, context.InterpreterConfiguration.GetPrefixPath()) + "/**/*"; | ||
| var watcher = new FileSystemWatcher() { GlobPattern = pattern }; | ||
| this._fileListener.AddExclude(watcher); |
There was a problem hiding this comment.
this is the fix. just exclude files under the interpreter if the interpreter is under the root workspace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… want to listen for file events in the interpreter folder. We already have conda and pip managers listening to them.
This fixes the issue of deleting an "env" folder then having PTVS quickly switching to the default env folder and tells Pylance to update its interpreter settings but the previous env folder file events are still being triggered and after Pylance updates its config it will keep refreshing analysis due to previous env file events.
fixes #8058