From dd04087482082219d2c86c827fcfe004477c50f5 Mon Sep 17 00:00:00 2001 From: Ran Gal Date: Tue, 27 Apr 2021 13:45:44 -0700 Subject: [PATCH] fixed the missing get_uv_vectors. the function name was changed to get_orthogonal_vectors and it seems that the refactoring changed some cases but not all. --- src/Geometry/Transform.jl | 1 + src/Optical/Emitters/Directions.jl | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/Geometry/Transform.jl b/src/Geometry/Transform.jl index 67121c78d..cc2022667 100644 --- a/src/Geometry/Transform.jl +++ b/src/Geometry/Transform.jl @@ -161,6 +161,7 @@ function get_orthogonal_vectors(direction::Vec3{T}) where {T<:Real} axis2 = normalize(cross(axis3, axis1)) return (axis2, axis3) end +export get_orthogonal_vectors #--------------------------------------- # 3D Transform / Local Frame diff --git a/src/Optical/Emitters/Directions.jl b/src/Optical/Emitters/Directions.jl index ac7874440..819ab71aa 100644 --- a/src/Optical/Emitters/Directions.jl +++ b/src/Optical/Emitters/Directions.jl @@ -60,7 +60,7 @@ struct RectGrid{T} <: AbstractDirectionDistribution{T} vvec::Vec3{T} function RectGrid(direction::Vec3{T}, halfangleu::T, halfanglev::T, numraysu::Integer, numraysv::Integer) where {T<:Real} - (uvec, vvec) = get_uv_vectors(direction) + (uvec, vvec) = get_orthogonal_vectors(direction) return new{T}(direction, halfangleu, halfanglev, numraysu, numraysv, uvec, vvec) end @@ -104,7 +104,7 @@ struct UniformCone{T} <: AbstractDirectionDistribution{T} vvec::Vec3{T} function UniformCone(direction::Vec3{T}, θmax::T, numsamples::Integer) where {T<:Real} - (uvec, vvec) = get_uv_vectors(direction) + (uvec, vvec) = get_orthogonal_vectors(direction) return new{T}(direction, θmax, numsamples, uvec, vvec) end