Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes concurrent error with registry #1659

Merged
merged 2 commits into from
May 9, 2024
Merged

Fixes concurrent error with registry #1659

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4e54dfd
Make the readers dictionary in the registry concurrent to avoid corru…
MaggieKimani1 May 8, 2024
15ce520
Implement PR feedback
MaggieKimani1 May 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/Microsoft.OpenApi/Reader/OpenApiReaderRegistry.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
// Licensed under the MIT license.

using System;
using System.Collections.Concurrent;
using System.Collections.Generic;
using Microsoft.OpenApi.Interfaces;

Expand All @@ -12,7 +13,7 @@ namespace Microsoft.OpenApi.Reader
/// </summary>
public static class OpenApiReaderRegistry
{
private static readonly Dictionary<string, IOpenApiReader> _readers = new(StringComparer.OrdinalIgnoreCase);
private static readonly ConcurrentDictionary<string, IOpenApiReader> _readers = new(StringComparer.OrdinalIgnoreCase);
MaggieKimani1 marked this conversation as resolved.
Show resolved Hide resolved

/// <summary>
/// Defines a default OpenAPI reader.
Expand All @@ -26,7 +27,7 @@ public static class OpenApiReaderRegistry
/// <param name="reader">The reader instance.</param>
public static void RegisterReader(string format, IOpenApiReader reader)
{
_readers[format] = reader;
_readers.AddOrUpdate(format, reader, (_, _) => reader);
}

/// <summary>
Expand Down
Loading