Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing query parameters for raw count endpoints #313

Closed
baywet opened this issue Nov 28, 2022 · 2 comments · Fixed by #320
Closed

Missing query parameters for raw count endpoints #313

baywet opened this issue Nov 28, 2022 · 2 comments · Fixed by #320
Assignees
@irvinesunday
Labels
priority:p2 Medium. Generally has a work-around and a smaller sub-set of customers is affected. SLA <=30 days type:bug A broken experience
Milestone
OData:1.2

Comments

@baywet
Copy link
Member

baywet commented Nov 28, 2022

The raw count endpoints ($count path item) are missing query parameters descriptions from the parent endpoint.

The service supports https://graph.microsoft.com/v1.0/me/messages/$count?$filter=isDraft eq false but the conversion process is missing the query parameters from messages on the $count path item.

Assemblies affected

1.2.0-preview8

Expected result

$count endpoints to have query parameters from the parent set/collection (filter, search and custom parameters)
http://docs.oasis-open.org/odata/odata/v4.01/odata-v4.01-part2-url-conventions.html#sec_AddressingtheCountofaCollection
@baywet baywet added the type:bug A broken experience label Nov 28, 2022
@baywet baywet added this to the OData:1.2 milestone Nov 28, 2022
@baywet baywet added the priority:p2 Medium. Generally has a work-around and a smaller sub-set of customers is affected. SLA <=30 days label Nov 28, 2022
@baywet baywet mentioned this issue Nov 28, 2022
Closed
@calebkiage
Copy link

calebkiage commented Dec 7, 2022 •
edited
Loading

@baywet, the headers e.g. Consistency-Level are also missing

@irvinesunday
Copy link
Contributor

@baywet, the headers e.g. Consistency-Level are also missing

@calebkiage this support was added in this PR: #305

@irvinesunday irvinesunday mentioned this issue Dec 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@irvinesunday irvinesunday

Labels
priority:p2 Medium. Generally has a work-around and a smaller sub-set of customers is affected. SLA <=30 days type:bug A broken experience
Projects
None yet
Milestone
OData:1.2
Development

Successfully merging a pull request may close this issue.

Adds OData query parameters to $count endpoints microsoft/OpenAPI.NET.OData
3 participants
@calebkiage @baywet @irvinesunday