Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[XPU] Support fused_rms_norm on XPU device #431

Merged
merged 1 commit into from
Aug 4, 2024

Conversation

ys950902
Copy link

For cuda fused_rms_norm is set by default, support fused_rms_norm on XPU device.

@rogerxfeng8
Copy link

@tjruwase would you help review?

@tjruwase tjruwase merged commit 53b241f into microsoft:main Aug 4, 2024
5 checks passed
@polisettyvarma
Copy link

@rogerxfeng8 @tjruwase should ipex import under try except block, right ?

@tjruwase
Copy link

tjruwase commented Aug 9, 2024

@polisettyvarma, good catch. I think ipex import could also be under if get_accelerator().device_name() == 'xpu': similar to cuda case.

@rogerxfeng8, can you please help fix. Thanks!

@ys950902
Copy link
Author

ys950902 commented Aug 9, 2024

@polisettyvarma, good catch. I think ipex import could also be under if get_accelerator().device_name() == 'xpu': similar to cuda case.

@rogerxfeng8, can you please help fix. Thanks!

Thanks for your suggestions, I have modified it on #436.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants