[Bug_Fix]Modify the config of args.deepspeed_config to args.deepspeed_config_dict #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ys950902
requested review from
tjruwase,
ShadenSmith,
conglongli,
awan-10,
eltonzheng,
minjiaz,
duli2012,
mrwyattii,
arashb,
xiaoxiawu-microsoft and
GuanhuaWang
as code owners
tjruwase
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr is to fix the potential bug on init, according to the method _create_ds_config_dict() https://github.com/microsoft/Megatron-DeepSpeed/blob/main/megatron/training.py#L148, the flag args.deepspeed_config is set to None and the deepspeed_config is set to the args.deepspeed_config_dict, so in init the config_dict_or_path=None.
When we change to MiCS_Init it will cause error because the deepspeed_config is None, should set to args.deepspeed_config_dict.